fix(deps): pin template systeminformation to 5.31.7 for JFrog cooldown#466
Merged
Merged
Conversation
Template artifact jobs run `npm install` (not `npm ci`) on a fresh copy, re-resolving the transitive `systeminformation@^5.31.6` (via @opentelemetry/instrumentation-host-metrics) to the newest published version. JFrog curation blocks versions younger than 7 days, causing an E403 in 'Install template dependencies' on PRs and prepare-release. Pin via the existing overrides block to 5.31.7 (the version AppKit is built against) so installs no longer chase immature releases. Signed-off-by: MarioCadenas <MarioCadenas@users.noreply.github.com>
Contributor
|
ditadi
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Install template dependenciesstep fails withE403in both CI jobs that build the template artifact:PR Template Artifact(ci.yml) on PRstemplate-artifact(prepare-release.yml) onmainBoth jobs run
npm install(notnpm ci) on a fresh copy of the template. That re-resolves the transitive requirementsysteminformation@^5.31.6(pulled in by@databricks/appkit→@opentelemetry/instrumentation-host-metrics@0.2.0) to the newest published version,5.31.11. JFrog's curation service blocks packages younger than 7 days, so the download 403s.This is not a one-off: because the step re-resolves to latest on every run, it breaks again on any fresh
systeminformationrelease inside its 7-day cooldown window. The monorepo itself is unaffected — its pnpm lock pins5.31.7and CI installs with--frozen-lockfile.Fix
Pin the transitive dep via the template's existing
overridesblock (same mechanism already used forvite/@opentelemetry/core) to5.31.7— the version AppKit is built/tested against and which JFrog already serves.template/package.json— add"systeminformation": "5.31.7"tooverrides.prepare-template-artifact.tscopiespackage.json(overrides included) into the install dir beforenpm install, so this is what unblocks CI.template/package-lock.json— update the committed entry5.31.11 → 5.31.7(integrity taken from the monorepo pnpm lock) so the source snapshot stays consistent.Verification
tools/check-template-deps.ts→ passes (pin check only inspectsdependencies/devDependencies).tools/check-template-lock-registry.ts→ passes (public npm registry only).Note: this pins
systeminformationfor scaffolded apps until someone bumps it — acceptable for a telemetry transitive dep and consistent with the other pinned overrides.