Skip to content

chore: dynamic ports in dev-mode #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
atilafassina wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: dynamic ports in dev-mode #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/dev-playground/.env.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
DATABRICKS_HOST=
DATABRICKS_APP_PORT=8001
DATABRICKS_WAREHOUSE_ID=
DATABRICKS_WORKSPACE_ID=
NODE_ENV='development'
Expand Down
10 changes: 8 additions & 2 deletions packages/appkit/src/plugins/server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ export class ServerPlugin extends Plugin {
public static DEFAULT_CONFIG = {
autoStart: true,
host: process.env.FLASK_RUN_HOST || "0.0.0.0",
port: Number(process.env.DATABRICKS_APP_PORT) || 8000,
port:
Number(process.env.DATABRICKS_APP_PORT) ||
(process.env.NODE_ENV === "development" ? 0 : 8000),
};

/** Plugin manifest declaring metadata and resource requirements */
Expand Down Expand Up @@ -257,7 +259,11 @@ export class ServerPlugin extends Plugin {
private logStartupInfo() {
const isDev = process.env.NODE_ENV === "development";
const hasExplicitStaticPath = this.config.staticPath !== undefined;
const port = this.config.port ?? ServerPlugin.DEFAULT_CONFIG.port;
const address = this.server?.address();
const port =
typeof address === "object" && address?.port
? address.port
: (this.config.port ?? ServerPlugin.DEFAULT_CONFIG.port);
const host = this.config.host ?? ServerPlugin.DEFAULT_CONFIG.host;

logger.info("Server running on http://%s:%d", host, port);
Expand Down
Loading