Add Architecture page and inline docs to campaign_pacing_app#13
Open
ameliachu wants to merge 2 commits into
Open
Add Architecture page and inline docs to campaign_pacing_app#13ameliachu wants to merge 2 commits into
ameliachu wants to merge 2 commits into
Conversation
Builds out the campaign_pacing_app as a multi-page Databricks App so the realtime monitor surfaces *what's happening* alongside *why it matters*: - New left-nav shell (AppLayout / LeftNav / PageHeader) routing to three pages: Realtime monitor, Architecture, Settings. - Architecture page: vertical data flow (Kafka → Spark RTM → Lakebase → FastAPI + React, joined to a Delta segment table) with a 1–2 sentence description per box and a Key Technologies legend linking to docs. - Realtime monitor: intro callout framing the campaign-manager persona — pacing decisions in ~2s via Lakebase + Spark RTM. - Tone system aligned to Databricks brand palette (navy = Kafka chain, blue = RTM + Lakebase, lava = Databricks App + Delta); tailwind.config.ts gains databricks-lava/navy ramps from the styleguide. - Icons cropped to glyph-only and sized consistently (apache-spark, delta-lake). - Backend: campaigns.py joins segment_definition from UC at read time; main.py SPA fallback now serves static files from dist so /favicon, /logos, /icons work in production. Co-authored-by: Isaac
5 tasks
Closes the loop on the persona callout: after the "Imagine you are a campaign manager…" pitch, point the reader to the Architecture tab for the under-the-hood story. CampaignDashboard accepts an optional onNavigateToArchitecture callback; AppLayout wires it up to flip the nav page state. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppLayout/LeftNav/PageHeader) so the app is now three pages: Realtime monitor, Architecture, Settings.tailwind.config.tsgainsdatabricks-lava/databricks-navyramps sourced fromadtech-measurement/docs/styleguide/colors.json.campaigns.pyjoinssegment_definitionfrommedia_advertising.segments.megacorp_segment_definitionsat read time so each card shows audience context;main.pySPA fallback now serves static files fromdist/(so/favicon,/logos,/iconswork in production).frontend/.gitignorefornode_modules/,dist/,.vite/.Out of scope (separate PRs)
segment_builder/) — stays on localmainfor its own PR.src/api/brand.py,src/core/brandfolder.py, Settings "Brand assets" panel) — dev-only scaffolding, intentionally excluded.Test plan
cd campaign_pacing_app/frontend && npm install && npm run buildsucceeds.uvicorn src.main:app --port 8000serves the built SPA at/with favicon + MegaCorp logo loading frompublic/.This pull request and its description were written by Isaac.