Merged
Conversation
…nai_highdicom_migration migrating models to generate .dcm seg files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses compatibility issues with VARIANT data types in model serving and metadata extraction, alongside updates to the VISTA3D notebook and de-identification workflows.
Key Changes
Variant Type Casting: Explicitly casts series_uid and metadata fields from VARIANT to STRING (using ::STRING) in monailabel_model/ModelServing.py. This ensures correct filtering, SQL querying, and compatibility with the underlying schema.
De-identification Workflow: Updates 03-Metadata-DeIdentification.py to enable zip extraction (extractZip=True) during the cataloging phase.
VISTA3D Updates: Refreshes monailabel_model/VISTA3D.ipynb, including configuration updates for Service Principals and volume handling.
MONAI 1.5.2: Includes various style fixes, performance improvements to the writer, and migration scripts for variant compatibility and latest dicom -> inference -> dicom-seg model path.