feat: add sandbox env injection case via cloud control#19383
feat: add sandbox env injection case via cloud control#19383KKould merged 9 commits intodatabendlabs:mainfrom
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b8e258c54
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
📚 Documentation Added I've created comprehensive documentation for the WORKER feature introduced in this PR: PR: databendlabs/databend-docs#3083 The documentation includes: New Documentation
Documentation Updates
The documentation covers all aspects of the WORKER feature as implemented in this PR, including syntax examples based on the test cases in . This should help users understand and effectively use the new WORKER management capabilities for UDF execution environments in Databend Cloud. |
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
The previous Resource interface in this PR was relatively simple and limited. It has since been expanded into separate Create / List / Alter / Delete interfaces and renamed to Worker. The syntax design also takes inspiration from CREATE WAREHOUSE (https://docs.databend.com/sql/sql-commands/ddl/warehouse/create-warehouse
), which is conceptually similar to our warehouse abstraction.
As with the earlier Resource design, each Worker corresponds to a single UDF, and the cloud starts the corresponding worker based on the function name.
Originally, ENV was intended to be passed via tags, similar to CREATE WAREHOUSE. However, due to the security risks of transmitting environment variables in plaintext, ENV configuration is now managed by the cloud instead.
example:
Tips:
At the moment, the experience of using environment variables in Sandbox UDFs may feel somewhat fragmented. After creating a UDF, users still need to manually configure the environment variables in the cloud, which is an area that could be improved.
Tests
Type of change
This change is