PLUGIN-1418: add argument for BQ temp staging bucket names #1177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsankit-google
force-pushed
the
PLUGIN-1418
branch
3 times, most recently
from
8bb475f to
889788a
Compare
fernst
reviewed
Nov 7, 2022
| // Get the bucket name for the specified location. | ||
| bucket = BigQueryUtil.getBucketNameForLocation(bucketPrefix, datasetLocation); | ||
| } | ||
| return bucket; |
Contributor
There was a problem hiding this comment.
How does this behave is the supplied Bucket is nullable and there is no prefix set? As far as I can tell, the returned bucket will be null.
If this is the case, please add the @Nullable annotation to this function.
Following question is: Should this function return a bucket name if not supplied and no prefix is set?
Contributor
Author
There was a problem hiding this comment.
Yeah, it is expected to return null in that case. Added the @Nullable annotation.
No we don't expect this method to return a bucket name if not supplied and if no prefix is set.
BigQuerySinkUtils#configureBucket and BigQuerySourceUtils#getOrCreateBucket expect the bucket argument to be nullable and will keep the existing behaviour.
fernst
requested changes
Nov 7, 2022
src/main/java/io/cdap/plugin/gcp/bigquery/sqlengine/BigQuerySQLEngine.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/gcp/bigquery/sqlengine/BigQuerySQLEngine.java
Outdated
Show resolved
Hide resolved
itsankit-google
force-pushed
the
PLUGIN-1418
branch
from
fe2b1fd to
e0e616a
Compare
itsankit-google
force-pushed
the
PLUGIN-1418
branch
from
e0e616a to
a6fff45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR of #1152.
It includes the support of creating common staging bucket for Dataplex and BQ pushdown plugins.