Skip to content

chore: remove ignored cargo build config#3948

Open
ZocoLini wants to merge 1 commit into
v3.1-devfrom
chore/ignored-build-config
Open

chore: remove ignored cargo build config#3948
ZocoLini wants to merge 1 commit into
v3.1-devfrom
chore/ignored-build-config

Conversation

@ZocoLini

@ZocoLini ZocoLini commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

In this PR I remove the profile.release sections in the crates Cargo.toml. They were not being applied bcs they need to be specified at the workspace level. I didn't write a replacement because the workspace already provides optimized profiles for the swift sdk builds

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • Chores
    • Removed custom release build profile configurations from multiple packages, standardizing release build settings across the project.

@thepastaclaw

thepastaclaw commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

✅ Review complete (commit 2168be3)

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0ccf41d1-a87f-4e07-9eb8-e1301de03479

📥 Commits

Reviewing files that changed from the base of the PR and between 2034316 and 2168be3.

📒 Files selected for processing (3)
  • packages/rs-sdk-ffi/Cargo.toml
  • packages/wasm-dpp/Cargo.toml
  • packages/wasm-sdk/Cargo.toml
💤 Files with no reviewable changes (3)
  • packages/wasm-sdk/Cargo.toml
  • packages/rs-sdk-ffi/Cargo.toml
  • packages/wasm-dpp/Cargo.toml

📝 Walkthrough

Walkthrough

Three crate manifests (packages/rs-sdk-ffi, packages/wasm-dpp, packages/wasm-sdk) each had their [profile.release] section removed. The deleted settings collectively covered lto, opt-level, panic, codegen-units, strip, and debug overrides.

Changes

Release Profile Cleanup

Layer / File(s) Summary
Remove [profile.release] from three crate manifests
packages/rs-sdk-ffi/Cargo.toml, packages/wasm-dpp/Cargo.toml, packages/wasm-sdk/Cargo.toml
Deletes per-crate [profile.release] blocks that individually set lto, opt-level, panic, codegen-units, strip, and debug overrides across all three packages.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • shumkov
  • QuantumExplorer
  • llbartekll

Poem

🐇 Hop, hop, away with the bloat!
Three Cargo files shed their coat.
No more lto = "fat" to weigh us down,
opt-level = "z" has left the town.
The workspace now decides our fate —
One profile to rule, centralized and great! 🌟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing cargo build configuration sections from Cargo.toml files across multiple packages.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/ignored-build-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

PR #3948 removes ignored [profile.release] blocks from three non-root workspace member Cargo.toml files (rs-sdk-ffi, wasm-dpp, wasm-sdk). Cargo only honors profiles defined at the workspace root, so these sections were dead config; iOS builds use workspace-level release-ios/dev-ios profiles and wasm builds inject release settings via cargo --config. Both agents and CodeRabbit found no actionable issues.

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.18%. Comparing base (96cba16) to head (2034316).
⚠️ Report is 2 commits behind head on v3.1-dev.

Additional details and impacted files
@@              Coverage Diff              @@
##           v3.1-dev    #3948       +/-   ##
=============================================
+ Coverage     52.54%   87.18%   +34.63%     
=============================================
  Files            11     2632     +2621     
  Lines          1707   327563   +325856     
=============================================
+ Hits            897   285592   +284695     
- Misses          810    41971    +41161     
Components Coverage Δ
dpp 87.70% <ø> (∅)
drive 86.14% <ø> (∅)
drive-abci 89.45% <ø> (∅)
sdk ∅ <ø> (∅)
dapi-client ∅ <ø> (∅)
platform-version ∅ <ø> (∅)
platform-value 92.20% <ø> (∅)
platform-wallet ∅ <ø> (∅)
drive-proof-verifier 49.55% <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ZocoLini ZocoLini force-pushed the chore/ignored-build-config branch from 2034316 to 2168be3 Compare June 23, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants