chore: remove ignored cargo build config#3948
Conversation
|
✅ Review complete (commit 2168be3) |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (3)
📝 WalkthroughWalkthroughThree crate manifests ( ChangesRelease Profile Cleanup
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
thepastaclaw
left a comment
There was a problem hiding this comment.
Code Review
PR #3948 removes ignored [profile.release] blocks from three non-root workspace member Cargo.toml files (rs-sdk-ffi, wasm-dpp, wasm-sdk). Cargo only honors profiles defined at the workspace root, so these sections were dead config; iOS builds use workspace-level release-ios/dev-ios profiles and wasm builds inject release settings via cargo --config. Both agents and CodeRabbit found no actionable issues.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3.1-dev #3948 +/- ##
=============================================
+ Coverage 52.54% 87.18% +34.63%
=============================================
Files 11 2632 +2621
Lines 1707 327563 +325856
=============================================
+ Hits 897 285592 +284695
- Misses 810 41971 +41161
🚀 New features to boost your workflow:
|
2034316 to
2168be3
Compare
In this PR I remove the profile.release sections in the crates Cargo.toml. They were not being applied bcs they need to be specified at the workspace level. I didn't write a replacement because the workspace already provides optimized profiles for the swift sdk builds
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit