Skip to content

feat: support platform 4 #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HashEngineering wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: support platform 4 #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6060767
chore: start 4.0.0-RC2-SNAPSHOT
HashEngineering Jun 15, 2026
a5ad22a
feat: update to platform 4.0.0-rc2
HashEngineering Jun 15, 2026
bc05640
fix: improve txmetadata for giftcards
HashEngineering Jun 19, 2026
81a49dc
fix: rename note to order
HashEngineering Jun 19, 2026
ca59469
fix: TxMetadataItem.getSize takes a version number
HashEngineering Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ Build the android libraries to publish to Maven Central:
```
### Use in other projects
```groovy
dppVersion = "2.0.5"
dppVersion = "4.0.0-SNAPSHOT"

@coderabbitai coderabbitai Bot Jun 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Align the documented dependency version with the project’s bumped version.

At Line 55, README uses 4.0.0-SNAPSHOT, while the root build version is now 4.0.0-RC2-SNAPSHOT. This can mislead consumers into pulling a non-matching artifact.

Suggested doc fix 
-dppVersion = "4.0.0-SNAPSHOT"
+dppVersion = "4.0.0-RC2-SNAPSHOT"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
dppVersion = "4.0.0-SNAPSHOT"
dppVersion = "4.0.0-RC2-SNAPSHOT"
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@README.md` at line 55, The dppVersion variable in the README.md documentation
is set to "4.0.0-SNAPSHOT" but the project's actual version has been bumped to
"4.0.0-RC2-SNAPSHOT". Update the dppVersion value in the README to match the
current project version to prevent users from pulling mismatched artifacts.
Locate the dppVersion assignment and change it to reflect the correct bumped
version from the root build configuration.

dependencies {
implementation "org.dashj.platform:dash-sdk-java:$dppVersion"
implementation "org.dashj.platform:dash-sdk-kotlin:$dppVersion" // dpp
Expand Down
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
buildscript {
ext.version = '2.0.5'
ext.version = '4.0.0-RC2-SNAPSHOT'
ext.kotlin_version = '2.1.20'
ext.dashj_version = '22.0.1'
repositories {
Expand Down
Loading
Loading