fix: prevent wallet deletion on screenshot during backup reminder

[bfoss765]

Summary

• Fixed a bug where taking a screenshot during the backup reminder flow (scenario 2) would incorrectly delete all wallets and create a new passphrase
• Screenshots now only show a warning message without any destructive wallet operations

Background

There are 4 scenarios when users can view their recovery phrase:

1. After onboarding (backup wallet flow)
2. After some time (backup reminder) ← this was broken
3. Via shortcut bar "Backup wallet" button
4. Via Security | View Recovery Phrase

Scenario 2 had shouldCreateNewWalletOnScreenshot returning true, which triggered wallet deletion on screenshot. This is now fixed to return false.

Test plan

• Trigger backup reminder flow
• Navigate to recovery phrase screen
• Take screenshot
• Verify warning dialog appears but wallet is NOT deleted/recreated

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Updated backup information screen behavior to ensure consistent wallet handling during screenshot detection, removing conditional logic that previously varied based on screen type.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

A computed property in BackupInfoViewController that determines screenshot behavior was modified. The shouldCreateNewWalletOnScreenshot property implementation was changed from a conditional type check to always return false.

Changes

Cohort / File(s)	Summary
Screenshot Behavior Logic DashWallet/Sources/UI/Setup/SecureWallet/BackupInfo/BackupInfoViewController.swift	Modified computed property shouldCreateNewWalletOnScreenshot from type == .reminder to false, removing conditional logic and forcing constant false return value

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A screenshot creeps near, but lo!
No wallet spawn shall ever go—
A simple false declares it clear,
The backup reminder's crystal sphere!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and specifically describes the main change: preventing wallet deletion on screenshot during backup reminder.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

DashWallet/Sources/UI/Setup/SecureWallet/BackupInfo/BackupInfoViewController.swift (1)

248-250: Critical security fix correctly implemented.

The change from type == .reminder to always false correctly prevents the destructive wallet deletion bug during backup reminder screenshots. This is the right fix - screenshots should never trigger wallet deletion in any scenario.

Optional: Consider adding documentation for future maintainability

Since this property now always returns false (and should remain that way for security), consider adding a comment explaining the reasoning:

 extension BackupInfoViewController {
+    /// Always returns false to prevent destructive wallet operations on screenshot.
+    /// Screenshots should only show a warning dialog, never delete/recreate wallets.
     var shouldCreateNewWalletOnScreenshot: Bool {
         false
     }
 }

This helps future maintainers understand why the property exists and why it should remain false.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 70de58e and d8dd549.

📒 Files selected for processing (1)

• DashWallet/Sources/UI/Setup/SecureWallet/BackupInfo/BackupInfoViewController.swift

🧰 Additional context used

📓 Path-based instructions (2)

**/*.swift

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.swift: Use SwiftUI for all new UI components. Do NOT create new UIKit ViewControllers, XIB files, or Storyboards. Use thin UIViewController wrappers only when integrating with existing UIKit navigation.
Always use guard statements instead of force unwrapping for optional coordinates (latitude, longitude). Never force unwrap latitude! or longitude! - use guard with error handling.
For generic type inference in Swift closures, add explicit return type annotations (e.g., { merchant -> MerchantAnnotation? in }) when compilation fails with generic parameter errors.
In SwiftUI conditional compilation, use computed properties instead of inline #if statements to avoid buildExpression errors. Move complex conditions into dedicated computed properties.
For dictionary initialization with conditional compilation, use closure-based initialization instead of inline conditionals to avoid syntax errors.
When removing debug print statements, ensure switch cases remain valid (add break if case becomes empty). Never leave empty switch cases.
Conditional compilation in Swift: use #if DASHPAY for DashPay features and #if PIGGYCARDS_ENABLED for PiggyCards features. Wrap all provider-specific code in appropriate flags.
Always use debug flags like #if DEBUG to wrap debug print statements. Remove debug logging before release commits. Search for print(" statements before any release.
Use emoji prefixes in debug logs for easy filtering: 🔍 for search, 📍 for location, 🗺️ for map, 🎯 for targeted debugging. This improves ability to filter console output.
Always validate CLLocationCoordinate2D.isValid before using coordinates. Implement fallback chains for CTX API data. Test coordinate edge cases thoroughly in unit tests.
Use os_log framework for production-safe logging instead of print statements. os_log messages are only logged in debug builds and stripped in release builds.

Files:

• DashWallet/Sources/UI/Setup/SecureWallet/BackupInfo/BackupInfoViewController.swift

**/*.{swift,m,h}

📄 CodeRabbit inference engine (CLAUDE.md)

Use 4-space indentation and 180-character line limit (100 recommended). Follow NYTimes Objective-C Style Guide for ObjC code. Use SwiftFormat/SwiftLint for Swift code formatting.

Files:

• DashWallet/Sources/UI/Setup/SecureWallet/BackupInfo/BackupInfoViewController.swift

🧠 Learnings (2)

📚 Learning: 2025-12-17T21:42:15.776Z

Learnt from: CR
Repo: dashpay/dashwallet-ios PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-17T21:42:15.776Z
Learning: Applies to DashWallet/Sources/Models/Uphold/DWUpholdMainnetConstants.m : The DWUpholdMainnetConstants.m file gets automatically formatted by the clang-format build phase script, adding unwanted blank lines. Restore this file before committing if it only has whitespace changes.

Applied to files:

• DashWallet/Sources/UI/Setup/SecureWallet/BackupInfo/BackupInfoViewController.swift

📚 Learning: 2025-09-05T04:46:12.717Z

Learnt from: HashEngineering
Repo: dashpay/dashwallet-ios PR: 728
File: DashWallet.xcodeproj/project.pbxproj:1595-1599
Timestamp: 2025-09-05T04:46:12.717Z
Learning: In iOS projects, the `DashWallet.xcodeproj/project.pbxproj` file is automatically generated and managed by Xcode. Manual changes to this file should not be made, and the changes shown in diffs are typically the result of Xcode updating project configuration, dependencies, or build settings.

Applied to files:

• DashWallet/Sources/UI/Setup/SecureWallet/BackupInfo/BackupInfoViewController.swift

[HashEngineering]

Very simple solution.