chore: prepare v23.1.5 release by thepastaclaw · Pull Request #7371 · dashpay/dash

thepastaclaw · 2026-06-19T11:11:30Z

Issue being fixed or feature implemented

Prepare the v23.1.x branch for Dash Core v23.1.5.

This release-prep PR is intentionally minimal. The v23.1.5 release notes only
cover the commits after 9adc0b16f93d15fe065692cbe77f3950419db0cb currently on
v23.1.x.

What was done?

Bumped the release version from v23.1.4 to v23.1.5 in configure.ac.
Added v23.1.5 to the Flatpak metainfo release list.
Regenerated manpages from freshly built v23.1.5 binaries.
Generated contrib/debian/examples/dash.conf with contrib/devtools/gen-dash-conf.sh.
Archived the current v23.1.4 release notes to
doc/release-notes/dash/release-notes-23.1.4.md.
Replaced doc/release-notes.md with scoped v23.1.5 notes covering:
- dash#7368: corrected the checkpoint hash for height 2487500.
- dash#7369: updated v23.1.4 release notes wording.

How Has This Been Tested?

Validation performed locally:

git diff --check
Full-feature Linux container build (--with-gui=qt5, ZMQ, UPnP, NAT-PMP) of dashd, dash-cli, dash-tx, dash-wallet, dash-util, and dash-qt.
contrib/devtools/gen-manpages.py using the freshly built v23.1.5 binaries.
contrib/devtools/gen-dash-conf.sh using the freshly built v23.1.5 dashd.
python3 test/lint/lint-whitespace.py
python3 test/lint/lint-files.py
python3 test/lint/lint-python.py
Confirmed doc/release-notes/dash/release-notes-23.1.4.md is an exact copy
of the previous doc/release-notes.md from upstream/v23.1.x.
Parsed contrib/flatpak/org.dash.dash-core.metainfo.xml with Python
xml.etree.ElementTree.
Reviewed the post-9adc0b16f93d15fe065692cbe77f3950419db0cb commit range to
keep the v23.1.5 notes scoped to the two minor changes requested.
Ran the mandatory pre-PR code-review gate: recommendation ship.

The generated artifacts were rebuilt in an Ubuntu 24.04 container from the current PR head.

Breaking Changes

None.

Checklist:

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated relevant unit/integration/functional/e2e tests
I have made corresponding changes to the documentation
I have assigned this pull request to a milestone (for repository code-owners
and collaborators only)

github-actions · 2026-06-19T11:11:57Z

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

thepastaclaw · 2026-06-19T11:12:07Z

@coderabbitai review

coderabbitai · 2026-06-19T11:12:14Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

PastaPastaPasta

utACK 2a86d30

Plan is to merge this into v23.1.x; ff to master, then merge master into develop.

thepastaclaw · 2026-06-19T11:15:05Z

✅ Review complete (commit 01640b9)

coderabbitai · 2026-06-19T11:15:50Z

Walkthrough

This PR prepares the Dash Core v23.1.5 release. configure.ac increments _CLIENT_VERSION_BUILD from 4 to 5. All six man pages (dash-cli, dash-qt, dash-tx, dash-util, dash-wallet, dashd) are updated to reference v23.1.5, and their chain parameter hash values are updated. The Flatpak AppStream metainfo receives a new <release> entry for version 23.1.5 dated 2026-06-19. The top-level doc/release-notes.md is replaced with v23.1.5 content, and the v23.1.4 release notes are archived as a new historical document doc/release-notes/dash/release-notes-23.1.4.md.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

dashpay/dash#7369: Modifies doc/release-notes.md in the same way — updating the top-level Dash Core patch release header and intro text — for the immediately preceding v23.1.4 release.

Suggested reviewers

UdjinM6

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly describes the main purpose of the PR - preparing the v23.1.5 release by updating version numbers and release documentation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The pull request description clearly describes the release preparation for v23.1.5, detailing all changes made, testing performed, and breaking changes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

thepastaclaw

Code Review

Release-prep PR for v23.1.5 is narrowly scoped and internally consistent (version bump, Flatpak entry, archived v23.1.4 notes, scoped v23.1.5 notes). One issue: the regenerated v23.1.5 manpages still document the pre-fix mainnet -assumevalid hash, contradicting the corrected consensus.defaultAssumeValid shipped in this release.

🟡 1 suggestion(s)

1 additional finding(s) omitted (not in diff).

🤖 Prompt for all review comments with AI agents

These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.

In `doc/man/dashd.1`:
- [SUGGESTION] doc/man/dashd.1:26: Regenerate manpages — stale mainnet -assumevalid default
  The manpages are bumped to v23.1.5, but the documented mainnet `-assumevalid` default is still `000000000000000718ed026ebd644a8b70b42d4cbd7b25304c066c9bf15f85b7` (the pre-fix value at height 2421800). The v23.1.x source now sets `consensus.defaultAssumeValid` to `00000000000000119fe42827219e0686d3f7b494ae65f823194c740c5dbab492` at height 2487500 (src/chainparams.cpp:222), and src/init.cpp:549 formats that value into the help string captured by help2man. `doc/man/dash-qt.1:28` carries the same stale value. Since fixing this checkpoint hash is the headline change of v23.1.5 (dash#7368), the generated manpages should be regenerated against the updated binaries so they don't ship documenting the wrong runtime default.

UdjinM6 · 2026-06-19T11:37:41Z

the regenerated v23.1.5 manpages still document the pre-fix mainnet -assumevalid hash

Good catch!

thepastaclaw · 2026-06-19T11:41:54Z

Pushed ce982ac to address review feedback:

updated generated doc/man/dashd.1 and doc/man/dash-qt.1 to document the corrected mainnet -assumevalid default
corrected the v23.1.4 older-release date to Jun/18/2026

Validation: git diff --check; explicit assertions that the stale manpage hash is gone and the corrected hash/date are present.

@coderabbitai review

coderabbitai · 2026-06-19T11:42:10Z

@thepastaclaw: Thank you for the update! I'll review the new commit ce982ac addressing the corrected mainnet -assumevalid hash in the manpages and the v23.1.4 older-release date fix.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

UdjinM6 · 2026-06-19T11:48:57Z

Wait, the old hash is not a broken one, it's the one we had before the release. So manpages were not re-generated actually, they were hand-patched in 23.1.4. We should update testnet hash in manpages too.

thepastaclaw · 2026-06-19T11:54:06Z

Thanks, good clarification. Pushed 52e71dc to sync the testnet -assumevalid value in doc/man/dashd.1 and doc/man/dash-qt.1 as well.

The manpages now match src/chainparams.cpp for both:

mainnet: 00000000000000119fe42827219e0686d3f7b494ae65f823194c740c5dbab492
testnet: 000000541a23f9db7411cddbe50f9f1ebd4aa7108ebdcad62214753f648c0239

Validation: git diff --check; explicit assertions that both old manpage values are gone and the current mainnet/testnet defaults are present.

@coderabbitai review

coderabbitai · 2026-06-19T11:54:25Z

@thepastaclaw: Thanks for the follow-up! I'll review commit 52e71dc6d735 which syncs the testnet -assumevalid value in doc/man/dashd.1 and doc/man/dash-qt.1 alongside the already-corrected mainnet hash.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

thepastaclaw

Code Review

Release-prep PR for v23.1.5 is minimal and consistent: configure.ac bump, manpage regeneration, Flatpak metainfo, release-notes scope, and archival of v23.1.4 notes all line up. The prior older-SHA finding about the stale mainnet -assumevalid hash in generated manpages is fixed on this head (dashd.1 and dash-qt.1 both show the corrected default). One docs nitpick about the Credits handle.

💬 1 nitpick(s)

UdjinM6

utACK 52e71dc

thepastaclaw

Code Review

Release-prep PR for v23.1.5 is narrowly scoped to version metadata, regenerated manpages, Flatpak release entry, archived v23.1.4 notes, and a new scoped v23.1.5 notes file. Verified the prior -assumevalid manpage mismatch is resolved on this head (dashd.1 and dash-qt.1 mainnet/testnet hashes match src/chainparams.cpp:222 and :421). Two minor release-notes issues remain: the set-of-changes compare link spans from the v23.1.4 tag and over-reports v23.1.4-era commits beyond the scoped notes, and the credit line uses a noreply GitHub handle instead of the canonical maintainer name used in prior releases.

🟡 1 suggestion(s)

1 carried-forward finding(s) already raised on this PR; not re-posting as new inline comments.

🤖 Prompt for all review comments with AI agents

These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.

In `doc/release-notes.md`:
- [SUGGESTION] doc/release-notes.md:70: Compare link starts at v23.1.4 tag and over-reports commits outside the scoped v23.1.5 notes
  The notes are intentionally scoped to commits after the post-v23.1.4 merge `9adc0b16f93d15fe065692cbe77f3950419db0cb`, but the `set-of-changes` link compares from the `v23.1.4` tag. Verified locally: `git log v23.1.4..HEAD` includes 12 commits (v23.1.4 release-prep, the QSIGSHARES early-bail-out fix, the ZMQ dtor fix, the v23.1.4 merge), while `git log 9adc0b16..HEAD` includes only the 7 commits that belong to v23.1.5. As written, the "detailed set of changes" link advertises changes that are not part of the v23.1.5 release. Use the post-v23.1.4 merge SHA as the compare base so the link matches the scoped content.

thepastaclaw · 2026-06-19T12:05:20Z

Pushed 0d5f682 to address the current-head review finding: updated the set-of-changes compare link to start from 9adc0b16f93d15fe065692cbe77f3950419db0cb, matching the scoped v23.1.5 release notes range.

I left the PastaClaw credit unchanged because that is the actual author identity for the scoped non-merge commits, not a noreply artifact to rewrite to Pasta.

Validation: git diff --check; assertion that the compare link uses the post-v23.1.4 merge SHA and no longer uses v23.1.4 as the base.

@coderabbitai review

coderabbitai · 2026-06-19T12:05:39Z

@thepastaclaw: Thanks for the follow-up! I'll review commit 0d5f68203b4e which updates the set-of-changes compare link to anchor from the post-v23.1.4 merge SHA (9adc0b16f93d15fe065692cbe77f3950419db0cb), and I've noted your reasoning for keeping PastaClaw as the credited author identity.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

thepastaclaw

Code Review

Narrow v23.1.5 release-prep PR. All three prior automated-review findings are resolved or explicitly addressed by the author. One small docs nitpick: the new v23.1.4 entry in the older-releases list uses Jun/18/2026 but the Flatpak metadata and the actual v23.1.4 release commit are dated 2026-06-13.

💬 1 nitpick(s)

thepastaclaw · 2026-06-19T12:42:42Z

@/var/folders/l6/t44rtggx2q1bf0c68hz9t7xc0000gt/T/tmp.JCZVrQkmau

PastaPastaPasta · 2026-06-19T12:44:05Z

Generated contrib/debian/examples/dash.conf with contrib/devtools/gen-dash-conf.sh.

This is improper I believe. Please undo.

thepastaclaw

Code Review

Release-prep PR for v23.1.5 on v23.1.x is narrow and consistent: version bump, regenerated dash.conf and manpages, Flatpak metainfo entry, archived v23.1.4 notes, and scoped v23.1.5 release notes. The only carried-forward nitpick remains valid — the v23.1.4 'older releases' date disagrees with the Flatpak entry and the v23.1.4 release commit date.

1 carried-forward finding(s) already raised on this PR; not re-posting as new inline comments.

thepastaclaw

Code Review

Narrow v23.1.5 release-prep PR with version bump, regenerated manpages/dash.conf, Flatpak metadata, scoped release notes, and archival of v23.1.4 notes. All prior-SHA findings are resolved at this head: the manpage assumevalid hash matches the current source default, the compare-link base is correct, the PastaClaw credit is intentional per the author, and the v23.1.4 older-release date is now Jun/13/2026 matching the v23.1.4 tag/Flatpak entry. No defects identified.

Note: posted as a COMMENT review because GitHub does not allow approving my own PR.

thepastaclaw

Code Review

Narrow v23.1.5 release-prep PR with version bump, regenerated manpages/dash.conf, Flatpak metadata, scoped release notes, and archival of v23.1.4 notes. All prior-SHA findings are resolved at this head: the manpage assumevalid hash matches the current source default, the compare-link base is correct, the PastaClaw credit is intentional per the author, and the v23.1.4 older-release date is now Jun/13/2026 matching the v23.1.4 tag/Flatpak entry. No defects identified.

Note: posted as a COMMENT review because GitHub does not allow approving my own PR.

thepastaclaw · 2026-06-19T13:12:16Z

Restored contrib/debian/examples/dash.conf to the placeholder in 7b8cdab.

thepastaclaw · 2026-06-19T13:13:26Z

Final amended head 01640b9 keeps contrib/debian/examples/dash.conf as the placeholder and keeps the v23.1.4 older-release date at Jun/18/2026 per the GitHub release publication date.

thepastaclaw

Code Review

Clean v23.1.5 release-prep PR. Version bump, regenerated manpages (with correct mainnet/testnet assumevalid hashes), scoped release notes covering #7368 and #7369 with the correct compare base 9adc0b1, Flatpak metainfo entry, archived v23.1.4 notes, and the placeholder dash.conf correctly restored per maintainer feedback. All prior automated findings are resolved at this head.

Note: posted as a COMMENT review because GitHub does not allow approving my own PR.

thepastaclaw · 2026-06-19T14:08:40Z

CI note: the current red linux64-test / Test source is unrelated to this release-prep PR. The failing test is feature_dip4_coinbasemerkleroots.py, timing out while waiting for a quorum hash to appear in quorum list after mining the second quorum (wait_for_quorum_list / wait_until), while this PR only updates release metadata/docs/manpage values and restores contrib/debian/examples/dash.conf to the placeholder.\n\nThe remaining predict_conflicts red item is also informational here: GitHub reports mergeable=MERGEABLE, and the predictor failure was in the conflict-comment/update path after finding no conflict PRs.

UdjinM6

utACK 01640b9

PastaPastaPasta previously approved these changes Jun 19, 2026

View reviewed changes

PastaPastaPasta marked this pull request as ready for review June 19, 2026 11:14

UdjinM6 added this to the 23.1.5 milestone Jun 19, 2026

UdjinM6 reviewed Jun 19, 2026

View reviewed changes

Comment thread doc/release-notes.md Outdated