[WIP] Implement MouseGestureHandler#42
Draft
ilyasakin wants to merge 1 commit intodashersw:masterfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I consider this main implementation to be somewhat finished and ready to be reviewed.
There are still some issues that need tracking and need to be addressed in this PR -which I plan to address in couple of days-:
tab-viewcomponent we usetouchendevent instead oftap. Which is not compatible with this implementation. But, mobile will still work. Not sure if this is a breaking change.tab-viewcomponent'stouchendevent totap. It does work but, it also clicks the item underneath it. For example, inerste-demo, if you clickShowswith a mouse, it will also click a movie. I'm suspecting this is some sort of an event-bubbling issue.