Convert project to Vite and TypeScript #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
dashed
commented
Dec 20, 2025
dashed
commented
- Convert source code from CommonJS to TypeScript (src/index.ts)
- Replace Babel with Vite for building ESM and CJS bundles
- Replace Flow with TypeScript for type checking
- Replace Jest with Vitest for testing
- Migrate from yarn to pnpm as package manager
- Add ESLint flat config with TypeScript support
- Remove legacy config files (Babel, Flow, Travis CI, Renovate)
- Generate proper TypeScript declarations with vite-plugin-dts
- Convert source code from CommonJS to TypeScript (src/index.ts) - Replace Babel with Vite for building ESM and CJS bundles - Replace Flow with TypeScript for type checking - Replace Jest with Vitest for testing - Migrate from yarn to pnpm as package manager - Add ESLint flat config with TypeScript support - Remove legacy config files (Babel, Flow, Travis CI, Renovate) - Generate proper TypeScript declarations with vite-plugin-dts
- Add Makefile with targets: install, build, test, lint, typecheck, clean, ci - Add GitHub Actions workflow that runs CI on Node 18, 20, and 22 - Workflow triggers on push/PR to master/main branches
- Replace Travis CI badge with GitHub Actions badge - Update install examples to show pnpm first - Change usage example to ESM import syntax - Add TypeScript usage section with Comparator type example - Update development section with pnpm and Make commands - Update prerequisites to Node.js v18+ and pnpm
Expand test coverage from 16 to 79 test cases organized into categories: - Primitive values: strings, numbers, booleans, symbols, bigints - Special values: NaN, +0/-0, Infinity, null, undefined - Objects: empty, shallow equal, key order, inherited/non-enumerable props - Arrays: empty, same elements, different lengths, sparse arrays - Mixed types: array vs object, Date, RegExp, Map, Set, functions - Customizer function: arguments, this binding, return value handling - Edge cases: numeric keys, undefined values, many keys, circular refs, typed arrays, ArrayBuffer, Error, Promise, WeakMap/WeakSet Tests document actual shallowequal behavior including that objects with no enumerable own properties (Date, RegExp, Map, Set) compare as equal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.