Open
Conversation
* Updated colapse algorithm * updated setup * added optional skips * added if to check if cdmconnector is installed * updated setup * updated test * dep update fixes * Updated setup * fixed eunomia download? * made tests faster * updated tests * revamped tests * updated checks * removed dfer * updated eunomia_data_folder * updated setup * updated path * fixed reproduced error from actions * comment out CG to see if DatabaseConnector overrides some CDMConnector functions * added stats for setNames * explicitly load stats * updated tests * updated tests
* Moved dependencies to suggests * Updated setup * download through CDMConnector * download both * Updated setup * Replaced stringr with stringi * Fixed tests and updated setup * Fixed warnings * removed png * removed stray stringr call * updated action * updated arg * ignore vignettes * moved args * updated example
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
Author
|
@ablack3 Your fix seems to work for ODBC Spark. But now ODBC Snowflake is failing. Not sure if that is internal to TreatmentPatterns or somthing similar to your suggested fix for Spark. |
Collaborator
Hmm can you point me to the error? It looks like the current develop branch is passing on snowflake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.