Skip to content

DeCo. Comment out assert(nameOffset != null ...) #4132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scheglov wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DeCo. Comment out assert(nameOffset != null ...) #4132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/src/model/model_element.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,8 +588,11 @@ abstract class ModelElement
final lineInfo = unitElement.lineInfo;

final nameOffset = element.firstFragment.nameOffset;
assert(nameOffset != null && nameOffset >= 0,
'Invalid location data, $nameOffset, for element: $fullyQualifiedName');
// TODO(scheglov): For extension types, or with primary constructors
// and declaring formal parameters, the field has no declaration, so
// no name offset.
// assert(nameOffset != null && nameOffset >= 0,
// 'Invalid location data, $nameOffset, for element: $fullyQualifiedName');
if (nameOffset != null && nameOffset >= 0) {
return lineInfo.getLocation(nameOffset);
}
Expand Down