Avoid image copy in vng opencl code#20100
Closed
jenshannoschwalm wants to merge 1 commit intodarktable-org:masterfrom
Closed
Avoid image copy in vng opencl code#20100jenshannoschwalm wants to merge 1 commit intodarktable-org:masterfrom
jenshannoschwalm wants to merge 1 commit intodarktable-org:masterfrom
Conversation
jenshannoschwalm
added
scope: performance
Member
|
I don't think this fit in 5.4.1 as not a bug. Only if the performance improvement is quite important we may consider this for 5.4.1. So what you're take on this @jenshannoschwalm ? |
Collaborator
Author
|
Its pretty small so only to master. |
jenshannoschwalm
force-pushed
the
less_opencl_vng_copy
branch
2 times, most recently
from
baad13c to
77dc1e7
Compare
jenshannoschwalm
force-pushed
the
less_opencl_vng_copy
branch
from
77dc1e7 to
7538bc0
Compare
We had some image copy operations while doing the vng opencl processing. Removed them for performance, no additional cl_mem is used. Minor renaming and additional comments to make code understandable.
jenshannoschwalm
force-pushed
the
less_opencl_vng_copy
branch
from
7538bc0 to
5cedc87
Compare
Collaborator
Author
|
Marked as draft as will be rebased after the other OpenCL stuff got merged |
Collaborator
Author
|
We don't need this as it's integrated - in a better way - in #20211 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had some image copy operations while doing the vng opencl processing. Removed them for performance, no additional cl_mem is used.
Minor renaming and additional comments to make code understandable.