feat: add product review, strategist, retro skills + bisectable ship commits#37
Merged
Conversation
…commits - /plan-ceo-review: founder-mode plan review with 3 scope modes, Error & Rescue Registry, 10 review sections - /strategist: conversational product strategy advisor (no context fork, stays in session) - /retro: engineering retrospective with persistent JSON metrics history - /ship: bisectable commit splitting by dependency layer, each commit passes tsc + biome
…skills # Conflicts: # skills/ship/SKILL.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces two new skills,
plan-ceo-reviewandretro, and enhances the commit workflow in theshipskill. These changes provide structured, self-contained workflows for plan reviews (with a strong product/CEO lens), engineering retrospectives with persistent metrics, and more robust, bisectable commit strategies for shipping code. The updates emphasize actionable output, rigorous process, and improved developer experience.New Skills
Plan Review Skill:
plan-ceo-review/SKILL.md, a comprehensive, self-contained guide for reviewing engineering plans through a founder/product lens. It defines three review modes (EXPAND, HOLD, REDUCE), detailed review sections (architecture, error handling, security, etc.), and mandates actionable outputs, diagrams, and one-question-per-issue discipline.Engineering Retrospective Skill:
retro/SKILL.md, an automated, argument-driven retrospective tool that analyzes commit history, computes metrics (velocity, test ratio, session patterns, hotspots), tracks trends, and saves persistent snapshots. It provides a narrative summary with actionable insights and improvement suggestions, all self-contained.Improvements to Commit Workflow
Commit Strategy and Validation:
ship/SKILL.mdreviewer agent to recommend splitting larger diffs into bisectable, dependency-ordered commits. Each commit must be independently valid (TypeScript strictness, formatting), with descriptive, conventional commit messages and no AI attribution.