feat: deslop advisory probe + PR-by-default workflow#35
Merged
Conversation
Adds a deslop advisory probe to the proof-of-work gate (the framework-agnostic sibling to react-doctor) and makes opening a PR the default workflow. - proof-of-work: detectDeslop / runDeslop / pure sumDeslopFindings; bun run proof appends a deslop pass when deslop-cli is a dependency. Advisory, opt-in, pinned. - permissions: narrow Bash(npx deslop:*) allow (+ regenerated docs). - rules/typescript.md + proof-of-work skill: document the probe. - rules/git.md: 'Open a PR by default' note. - .github/PULL_REQUEST_TEMPLATE.md: dogfoods the plain-English standard. typecheck + 449 tests + lint + lint:skills clean.
Resolves CHANGELOG + setup.ts version conflicts: keeps VERSION 11.16.0 (deslop is the newer feature) and orders changelog entries 11.16.0 → 11.15.2 → 11.15.1. Merged tree green: 449 tests, typecheck, lint, lint:skills.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Two things. First,
bun run proof(the gate that decides whether a diff is "review-ready") can now run deslop — a cross-file dead-code scanner — and report how many findings it sees, the same way it already runs react-doctor for React projects. It is advisory: the number is shown but never blocks the verdict, and it only runs if the project actually depends ondeslop-cli, so it stays out of the way everywhere else.Second, it makes opening a PR the default for our work instead of pushing straight to
main. Most Darkroom client projects review through PRs, so the guidance and a new repo PR template now reflect that — and this PR is the first one to use them.Summary
src/lib/proof-of-work.ts—detectDeslop/runDeslop/ puresumDeslopFindings(sums deslop's--jsonfinding-category arrays). AdvisoryGateResult;allGreenignores it.src/scripts/proof.ts— appends the deslop pass whendeslop-cliis in deps.config/30-permissions.json+ regenerateddocs/settings-reference.md— narrowBash(npx deslop:*).rules/typescript.md,skills/proof-of-work/SKILL.md— document the probe.rules/git.md— "Open a PR by default";.github/PULL_REQUEST_TEMPLATE.mdadded.Test Plan
bun run typecheckcleanbun test— 449 pass (added detectDeslop, sumDeslopFindings, deslop-advisory tests)bun run lint+bun run lint:skillscleanbun run proofself-run stays green — cc-settings has nodeslop-clidep, so the probe stays silent