Skip to content

Slice up widget store; add ui, prefs and feedback stores#239

Open
Cas Linden (CasLinden) wants to merge 7 commits into
developfrom
cas/slice-store
Open

Slice up widget store; add ui, prefs and feedback stores#239
Cas Linden (CasLinden) wants to merge 7 commits into
developfrom
cas/slice-store

Conversation

@CasLinden
Copy link
Copy Markdown
Contributor

@CasLinden Cas Linden (CasLinden) commented May 29, 2026

Summary

  • slice up widget-store into bite sized chunks
  • extract separate stores for feedback, ui and prefs
  • remove some unused store fields and methods
  • update imports
  • update tests

This does not achieve clean state taxonomy in the frontend. Rather, it implements the architecture to help us think about a clean model, and also implement modularity.

Out of scope followup:

  • further cleanup / unification of fields, renaming of slices / stores
  • rebuild type sharing from rust (would likely require some ?? undefined)
  • refactor "computeCurrentStep" to read store as a hook, and separate evolution state from step state
  • fixing the wdio tests that broke when clearPreview was reintroduced by cursor

Test Plan

on par with develop

Suite Pass Fail Skip
rust 317 0 2
vitest 93 0 0
basic-prompts 2 1 0
conversational 1 1 0
discard 2 0 0
manual-changes 2 0 0
modify 0 1 0
onboarding 0 1 0
smoke 4 0 0

Docs

  • Readme updated

@github-actions
Copy link
Copy Markdown
Contributor

Warnings
⚠️ Please assign this PR to someone (usually yourself).
⚠️ ❗ Big PR (3133 lines changed). Consider splitting it into smaller, focused changes.

📋 PR Overview

Lines changed 3133 (+1852 / -1281)
Files 15 added, 68 modified, 0 deleted
Draft / WIP no
Has Test Plan yes
New UI components no
New Storybook stories no
New Rust modules no
New TS source files yes (11)
New tests yes (3)
package.json touched no
Cargo.toml touched no
Infra / CI touched no

🔬 Coverage

Report Lines Statements Functions Branches
apps/native/coverage/coverage-summary.json 18.8% 18.8% 32.8% 54.9%

Generated by 🚫 dangerJS against 43a5c5f

@CasLinden Cas Linden (CasLinden) changed the title Cas/slice store Slice up widget store; add ui, prefs and feedback stores May 29, 2026
@czxtm
Copy link
Copy Markdown
Member

can you split the formatting and renames into a separate commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants