Require explicit local AI model names#237
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: cooper <czxtm@users.noreply.github.com>
Contributor
📋 PR Overview
🔬 Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove hard-coded local model fallbacks for Ollama/vLLM summary and evolution providers. Empty or whitespace-only model settings now produce a direct configuration error instead of attempting a guessed model. The settings UI also stops auto-populating local provider model names and validates that local providers have explicit models.
Fixes ENG-516
Test Plan
bun -F native test:unit -- ai-provider-validation.test.tsbun -F native buildcargo +stable test --manifest-path apps/native/src-tauri/Cargo.toml test_non_empty_trimmed_string_filters_empty_values(blocked by missing system librarygdk-3.0required by Tauri on this Linux runner)Docs