Allow to return nil from a defn of a component#64
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Мы уже несколько раз подорвались на коде вида
в тестах flag взведен, и все работает, т.к.
side-effectу нас возвращает неnil,но в проде он не взведен и приложение не запускается с ошибкой
"A component fn must not return nil"Можно было бы как-то внутри di вести учет nil компонентов, чтобы компонент для пользователя был настоящим
nilно я что-то не могу придумать такого случая в реальности:в этом случае сам компонент должен вернуть дефолтную реализацию.