add TraceID and TraceParent handling for grpc and client#717
Open
add TraceID and TraceParent handling for grpc and client#717
Conversation
Signed-off-by: majkio <michal.hodan@protonmail.com>
mikeee
reviewed
May 26, 2025
Member
mikeee
left a comment
There was a problem hiding this comment.
I think it'd be good to consolidate the getStringValueFromExtension() helper function to an internal package e.g. internal/structpb so that we're not duplicating code unnecessarily. I'd also in an ideal world like to see some debugging to differentiate between whether a key has a value declared as "" or whether the key is missing alltogether. What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added support for extracting TraceId and TraceParent from Cloud Events Extension
Issue reference
Please reference the issue this PR will close: #355
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: