Fix(bug): shutdown on iterator #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rator. Future TODO: figure out if it's ever a grpc.Future. Signed-off-by: Casper Nielsen <casper@diagrid.io>
Signed-off-by: Casper Nielsen <casper@diagrid.io>
3 tasks
acroca
reviewed
Feb 9, 2026
Signed-off-by: Casper Nielsen <casper@diagrid.io>
…sed and single grpc.Future _response_stream close methods Signed-off-by: Casper Nielsen <casper@diagrid.io>
acroca
approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle shutdown event where
_response_streamis a generator object and thus does not have direct access to.cancel(). Instead we get access to the gRPC stream cancel through.call.cancel().It's a bit obscured but, the Call object is of RpcContext which implements it.
I've run both test suites.