-
Notifications
You must be signed in to change notification settings - Fork 779
Separating Dapr Workflows documentation on Spring Boot to it's separate page #4975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d2de566 to
e28ede4
Compare
Signed-off-by: salaboy <Salaboy@gmail.com>
Removed duplicate information and streamlined the scenarios for configuring secrets access. Signed-off-by: rohit <50377477+caretak3r@users.noreply.github.com> Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
dd7dd60 to
51d0e5f
Compare
msfussell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some light editing. Please read the Dapr doc style recommendations. No "we" (instead use you or none) and minimize "will" to use the present tense as in this is how it works now.
sdkdocs/java/content/en/java-sdk-docs/spring-boot/sb-workflows-howto.md
Outdated
Show resolved
Hide resolved
sdkdocs/java/content/en/java-sdk-docs/spring-boot/sb-workflows-howto.md
Outdated
Show resolved
Hide resolved
sdkdocs/java/content/en/java-sdk-docs/spring-boot/sb-workflows-howto.md
Outdated
Show resolved
Hide resolved
sdkdocs/java/content/en/java-sdk-docs/spring-boot/sb-workflows-howto.md
Outdated
Show resolved
Hide resolved
sdkdocs/java/content/en/java-sdk-docs/spring-boot/sb-workflows-howto.md
Outdated
Show resolved
Hide resolved
…-howto.md Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
…-howto.md Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
…-howto.md Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
…-howto.md Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
…-howto.md Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
msfussell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixing some old details and separating workflows with spring boot to it's own page.
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Issue reference