MAR-227: Add GA4 signup_complete event for accurate conversion tracking#96
Merged
derensdima22 merged 5 commits intodevfrom Mar 24, 2026
Merged
MAR-227: Add GA4 signup_complete event for accurate conversion tracking#96derensdima22 merged 5 commits intodevfrom
derensdima22 merged 5 commits intodevfrom
Conversation
MAR-227: Fires signup_complete + sign_up GA4 events only after successful new account creation (not on page view or login). Changes: - withTracking.tsx: add logSignup() that fires gtag signup_complete with method, user_id, email_domain - GoogleButton.tsx: logLogin → logSignup for new registrations - FacebookButton.tsx: same - MetamaskButton.tsx: add logSignup after registerSignature success - RegisterForm.tsx: logLogin → logSignup for email registration - FirstStep.tsx: same - ThirdStep.tsx: same (temp password flow) Existing logLogin calls for returning users unchanged. logLogin now also fires GA4 login event (was a no-op before). This fixes the 2.8x GA4 conversion over-count: GA4 reported 220 conversions but backend had 77 actual signups because the event was firing on page view instead of actual account creation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fires
signup_completeGA4 event only after successful new account creation — not on page view or login. Fixes the 2.8x GA4 conversion over-count (220 reported vs 77 actual).Changes
withTracking.tsx: NewlogSignup()function that firessignup_complete+sign_upGA4 events. Also madelogLogin()actually fire a GA4loginevent (was a no-op returning an object).GoogleButton.tsx:logLogin→logSignupfor new registrations (existing user login unchanged)FacebookButton.tsx: SameMetamaskButton.tsx: AddedlogSignupafter successfulregisterSignatureRegisterForm.tsx:logLogin→logSignupfor email registrationFirstStep.tsx: SameThirdStep.tsx: Same (temp password flow)GA4 Events
signup_complete— custom event with: method (google/facebook/metamask/email), user_id, email_domainsign_up— standard GA4 event with: methodlogin— standard GA4 event (logLogin now functional)Test plan
signup_completeeventloginevent, NOTsignup_complete