Add txs for NFTStorefrontV2 / TopShotMarketV3 by bspowell · Pull Request #95 · dapperlabs/studio-platform-smart-contracts

bspowell · 2026-02-04T22:17:01Z

Changes

Added list tx for NFTStorefrontV2 with ability to handle multiple listings
Renamed delist files to keep naming style
Added DelistTopShotMarketV3 transaction
Added script tests

Deewai · 2026-02-09T18:06:12Z

atlas/transactions/user/delist_nftstorefront.cdc


    execute {
-        let listingResourceIDs: [Uint64] = [{{.listingResourceIDs}}]
+        let listingResourceIDs: [Uint64] = {{.ListingResourceIDs}}


why are you removing the array?

because I'm passing in an array, not a string with ids.

studio-platform-smart-contracts/atlas/embed.go

Line 134 in 82d3e1c

ListingResourceIDs []uint64

Deewai · 2026-02-09T18:06:21Z

atlas/transactions/user/delist_nftstorefrontv2.cdc


    execute {
-        let listingResourceIDs: [Uint64] = [{{.listingResourceIDs}}]
+        let listingResourceIDs: [Uint64] = {{.ListingResourceIDs}}


same as above

Deewai · 2026-02-09T18:07:26Z

atlas/transactions/user/delist_topshotmarketv3.cdc

+    let nftIds: [UInt64]
+
+    prepare(acct: auth(Storage, Capabilities) &Account) {
+        self.nftIds = {{.NftIds}}


Suggested change

self.nftIds = {{.NftIds}}

self.nftIds = [{{.NftIds}}]

Even though I'm passing in a []uint64? same as above? Or would you rather it be a connected list of ids in a string?

studio-platform-smart-contracts/atlas/embed.go

Line 163 in 82d3e1c

NftIds []uint64

Deewai · 2026-02-09T18:23:52Z

atlas/transactions/user/list_nftstorefrontv2.cdc

+        let PrivateCollectionPath = /storage/{{.NFTProductName}}CollectionProviderForNFTStorefront
+
+        // Temporary variable to handle capability assignment
+        var provider: Capability<auth(NonFungibleToken.Withdraw) &{NonFungibleToken.Collection}>? =
+            acct.storage.copy<Capability<auth(NonFungibleToken.Withdraw) &{NonFungibleToken.Collection}>>(from: PrivateCollectionPath)
+
+        if provider == nil {
+            provider = acct.capabilities.storage.issue<auth(NonFungibleToken.Withdraw) &{NonFungibleToken.Collection}>({{.NFTProductName}}.CollectionStoragePath)
+            acct.capabilities.storage.getController(byCapabilityID: provider!.id)!.setTag("{{.NFTProductName}}CollectionProviderForNFTStorefront")
+            // Save the capability to the account storage
+            acct.storage.save(provider!, to: PrivateCollectionPath)
+        }
+
+        self.nftProvider = provider
+        assert(self.nftProvider?.borrow() != nil, message: "Missing or mis-typed {{.NFTProductName}}.Collection provider")


we should use cap controllers https://github.com/onflow/nft-storefront/blob/main/transactions-v1/sell_item.cdc#L23

Suggested change

let PrivateCollectionPath = /storage/{{.NFTProductName}}CollectionProviderForNFTStorefront

// Temporary variable to handle capability assignment

var provider: Capability<auth(NonFungibleToken.Withdraw) &{NonFungibleToken.Collection}>? =

acct.storage.copy<Capability<auth(NonFungibleToken.Withdraw) &{NonFungibleToken.Collection}>>(from: PrivateCollectionPath)

if provider == nil {

provider = acct.capabilities.storage.issue<auth(NonFungibleToken.Withdraw) &{NonFungibleToken.Collection}>({{.NFTProductName}}.CollectionStoragePath)

acct.capabilities.storage.getController(byCapabilityID: provider!.id)!.setTag("{{.NFTProductName}}CollectionProviderForNFTStorefront")

// Save the capability to the account storage

acct.storage.save(provider!, to: PrivateCollectionPath)

}

self.nftProvider = provider

assert(self.nftProvider?.borrow() != nil, message: "Missing or mis-typed {{.NFTProductName}}.Collection provider")

var nftProviderCap: Capability<auth(NonFungibleToken.Withdraw) &{NonFungibleToken.Collection}>? = nil

// check if there is an existing capability/capability controller for the storage path

let nftCollectionControllers = acct.capabilities.storage.getControllers(forPath: collectionData.storagePath)

for controller in nftCollectionControllers {

if let maybeProviderCap = controller.capability as? Capability<auth(NonFungibleToken.Withdraw) &{NonFungibleToken.Collection}>? {

nftProviderCap = maybeProviderCap

break

}

}

// if there are no capabilities created for that storage path

// or if existing capability is no longer valid, issue a new one

if nftProviderCap == nil || nftProviderCap?.check() ?? false {

nftProviderCap = acct.capabilities.storage.issue<auth(NonFungibleToken.Withdraw) &{NonFungibleToken.Collection}>(

collectionData.storagePath

)

}

assert(nftProviderCap?.check() ?? false, message: "Could not assign Provider Capability")

self.nftProvider = nftProviderCap!

atlas/transactions/user/list_nftstorefrontv2.cdc

Deewai · 2026-02-09T18:27:21Z

atlas/transactions/user/list_nftstorefrontv2.cdc

+        if !acct.capabilities.get<&{{.NFTProductName}}.Collection>({{.NFTProductName}}.CollectionPublicPath)!.check() {
+            acct.capabilities.unpublish({{.NFTProductName}}.CollectionPublicPath)
+            acct.capabilities.publish(
+                acct.capabilities.storage.issue<&{{.NFTProductName}}.Collection>({{.NFTProductName}}.CollectionStoragePath),
+                at: {{.NFTProductName}}.CollectionPublicPath
+            )
+        }


Suggested change

if !acct.capabilities.get<&{{.NFTProductName}}.Collection>({{.NFTProductName}}.CollectionPublicPath)!.check() {

acct.capabilities.unpublish({{.NFTProductName}}.CollectionPublicPath)

acct.capabilities.publish(

acct.capabilities.storage.issue<&{{.NFTProductName}}.Collection>({{.NFTProductName}}.CollectionStoragePath),

at: {{.NFTProductName}}.CollectionPublicPath

)

}

if !acct.capabilities.get<&{{.NFTProductName}}.Collection>(collectionData.publicPath)!.check() {

acct.capabilities.unpublish(collectionData.publicPath)

acct.capabilities.publish(

acct.capabilities.storage.issue<&{{.NFTProductName}}.Collection>(collectionData.storagePath),

at: collectionData.publicPath

)

}

Deewai · 2026-02-09T18:27:56Z

atlas/transactions/user/list_nftstorefrontv2.cdc

+
+
+        let collectionRef = acct
+        .capabilities.borrow<&{{.NFTProductName}}.Collection>({{.NFTProductName}}.CollectionPublicPath)


Suggested change

.capabilities.borrow<&{{.NFTProductName}}.Collection>({{.NFTProductName}}.CollectionPublicPath)

.capabilities.borrow<&{{.NFTProductName}}.Collection>(collectionData.publicPath)

Deewai · 2026-02-09T18:31:09Z

atlas/embed.go

+	NFTProductName                   string
+	NFTContractAddress               string
+	NFTStorefrontV2ContractAddress   string
+	NFTIDs                           string // comma-separated, e.g. "123,456"


should be an array of uint64, you do the conversion to comma-separated string in ListNFTStorefrontV2TxScript. Same with the prices below. should be an array of integers(price in cents) and you do the conversion in the same function. SaleCommissionAmount should also be an integer(price in cent)

Deewai · 2026-02-09T18:32:06Z

atlas/embed_test.go

 	}
 }
+
+func TestDelistNFTStorefrontOutput(t *testing.T) {


these tests are not actually testing anything. It just logs stuff

I know, it helps see what is getting inputted

bspowell added 2 commits February 4, 2026 14:10

add list for NFTStorefrontV2 and renamed delist files

bf43f53

add new params

e6f872c

bspowell requested a review from a team as a code owner February 4, 2026 22:17

bspowell added 3 commits February 4, 2026 15:34

fix comissions and salecuts

c429789

add nba delist tx, tests, and fix txs

49e23a7

fix moved topshot delist to other delist scripts

82d3e1c

bspowell changed the title ~~Add list tx for NFTStorefrontV2~~ Add txs for NFTStorefrontV2 / TopShotMarketV3 Feb 9, 2026

Deewai reviewed Feb 9, 2026

View reviewed changes

atlas/transactions/user/list_nftstorefrontv2.cdc Show resolved Hide resolved

Deewai reviewed Feb 9, 2026

View reviewed changes

Deewai added 4 commits February 9, 2026 10:47

add array brackets for delist txns

22e7218

Update list_nftstorefrontv2.cdc

7c68190

use correct type

70d8823

Update embed.go

3377b92

-        let PrivateCollectionPath = /storage/{{.NFTProductName}}CollectionProviderForNFTStorefront
-        // Temporary variable to handle capability assignment
-        var provider: Capability<auth(NonFungibleToken.Withdraw) &{NonFungibleToken.Collection}>? =
-            acct.storage.copy<Capability<auth(NonFungibleToken.Withdraw) &{NonFungibleToken.Collection}>>(from: PrivateCollectionPath)
-        if provider == nil {
-            provider = acct.capabilities.storage.issue<auth(NonFungibleToken.Withdraw) &{NonFungibleToken.Collection}>({{.NFTProductName}}.CollectionStoragePath)
-            acct.capabilities.storage.getController(byCapabilityID: provider!.id)!.setTag("{{.NFTProductName}}CollectionProviderForNFTStorefront")
-            // Save the capability to the account storage
-            acct.storage.save(provider!, to: PrivateCollectionPath)
-        }
-        self.nftProvider = provider
-        assert(self.nftProvider?.borrow() != nil, message: "Missing or mis-typed {{.NFTProductName}}.Collection provider")
+       var nftProviderCap: Capability<auth(NonFungibleToken.Withdraw) &{NonFungibleToken.Collection}>? = nil
+        // check if there is an existing capability/capability controller for the storage path
+        let nftCollectionControllers = acct.capabilities.storage.getControllers(forPath: collectionData.storagePath)
+        for controller in nftCollectionControllers {
+            if let maybeProviderCap = controller.capability as? Capability<auth(NonFungibleToken.Withdraw) &{NonFungibleToken.Collection}>? {
+                nftProviderCap = maybeProviderCap
+                break
+            }
+        }
+        // if there are no capabilities created for that storage path
+        // or if existing capability is no longer valid, issue a new one
+        if nftProviderCap == nil || nftProviderCap?.check() ?? false {
+            nftProviderCap = acct.capabilities.storage.issue<auth(NonFungibleToken.Withdraw) &{NonFungibleToken.Collection}>(
+                collectionData.storagePath
+            )
+        }
+        assert(nftProviderCap?.check() ?? false, message: "Could not assign Provider Capability")
+        self.nftProvider = nftProviderCap!



		let collectionRef = acct
		.capabilities.borrow<&{{.NFTProductName}}.Collection>({{.NFTProductName}}.CollectionPublicPath)

Comments

Conversation

bspowell commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Deewai Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bspowell commented Feb 4, 2026 •

edited

Loading

Deewai Feb 9, 2026 •

edited

Loading