Open
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
…ng' into leo/background-storehouse-indexing
Makefile and build fixes
[Storehouse] Background storehouse indexing
[Flow EVM] Update to latest `ethereum/go-ethereum` version
…oof-list [Flow EVM] Handle empty RLP list in Cadence Arch `verifyCOAOwnershipProof()`
Update to Cadence v1.9.6
The network manager keeps a reference to the engine to send it messages, preventing it from being garbage collected even when stopped, until the conduit is closed. All engines *should* close their network conduits on shutdown, not just these, but limiting to these cases for now as only the cluster sync and message hub engines use distinct channel IDs for each epoch.
add AN compatibility for v0.45.0
add back quotes for DISABLE_ADX flag
FVM tx verifier improvements
Co-Authored-By: Ardit Marku <markoupetr@gmail.com>
This commit updates the following EVM functions to return raw result data if EVM call fails or user doesn't provide resultTypes: - CadenceOwnedAccount.callWithSigAndArgs - CadenceOwnedAccount.dryCallWithSigAndArgs - EVM.dryCallWithSigAndArgs This commit updates CadenceOwnedAccount.callWithSigAndArgs, CadenceOwnedAccount.dryCallWithSigAndArgs, and EVM.dryCallWithSigAndArgs to return raw result data if evm call failes or user doesn't provide resultTypes.
Pin tagged version of lockctx
Co-Authored-By: Ardit Marku <markoupetr@gmail.com>
go fix: remove obsolete +build directives
Co-authored-by: Tim Barry <21149133+tim-barry@users.noreply.github.com>
[Flow EVM] Add new EVM functions that can be used to reduce computation cost of transactions
[Access] Add index for account transactions
Currently, calling NewReadOnlyBlockView() incurs the overhead and computation cost of always reading a register from storage, and potentially also writing a register to the storage. Specifically, Emulator.NewReadOnlyBlockView() receives BlockContext param without actually using it. Creating BlockContext requires reading BlockProposal from storage, which incurs GetValue and potentially SetValue computation cost. This commit removes the unnecessary BlockContext param. This optimization reduces computation cost in these four EVM functions: - EVMAddress.balance() - EVMAddress.code() - EVMAddress.codeHash() - EVMAddress.nonce()
No longer necessary since go 1.22, see https://go.dev/wiki/LoopvarExperiment
The loop variable assigned by a range statement inherits the type of the
variable used to create the range, including signedness, so in
```
for i := range X { ... }
```
`i` has the same integer type as `X`.
slices package was introduced in go 1.21
…oposal-for-readonlyblockview [Flow EVM] Optimize and reduce computation cost of four EVM functions
Mockery fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.