DAOS-10535 tests: Remove daos-tests daos-*-tests-openmpi requirement by phender · Pull Request #8980 · daos-stack/daos

This feels like it should go into pipeline-lib rather than being repeated a dozen times here, and will need updating in the weekly-testing branch also. Unless there is something about doing that there that I am not seeing.

brianjmurrell · 2022-05-10T18:55:06Z

I wonder if a better approach is to have yet another [meta-]package, called daos-tests-internal, say, that Requires: %{name}-tests%{?_isa} = %{version}-%{release}, %{name}-client-tests-openmpi%{?_isa} = %{version}-%{release}, which we don't include in the public release and then go back to being able to update pipeline-lib.

phender · 2022-05-10T18:58:17Z

There is currently a difference in the daos master and release/2.2 branches in that the master branch no longer has a daos-server-tests-openmpi package.

phender · 2022-05-10T19:00:03Z

I wonder if a better approach is to have yet another [meta-]package, called daos-tests-internal, say, that Requires: %{name}-tests%{?_isa} = %{version}-%{release}, %{name}-client-tests-openmpi%{?_isa} = %{version}-%{release}, which we don't include in the public release and then go back to being able to update pipeline-lib.

We could do that, but it might be silly to define a daos-tests-internal package that only requires daos-client-tests-openmpi in the master branch.

brianjmurrell · 2022-05-10T19:03:26Z

We could do that, but it might be silly to define a daos-tests-internal package that only requires daos-client-tests-openmpi in the master branch.

Well, it would also requires daos-tests and generally considered to be the internal testing equivalent of users installing daos-tests. daos-client-tests-openmpi may very well not be the end of things/tests that we do not want to include in public releases.

phender · 2022-05-10T19:51:33Z

We could do that, but it might be silly to define a daos-tests-internal package that only requires daos-client-tests-openmpi in the master branch.

Well, it would also requires daos-tests and generally considered to be the internal testing equivalent of users installing daos-tests. daos-client-tests-openmpi may very well not be the end of things/tests that we do not want to include in public releases.

Would it though? Since daos-client-tests-openmpi requires daos-client-tests already there is no need for daos-tests-internal to also require the empty daos-tests to bring in the daos-client-tests requirement.

daosbuild1 · 2022-05-10T22:25:06Z

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-8980/4/display/redirect

brianjmurrell · 2022-05-11T14:39:22Z

Would it though? Since daos-client-tests-openmpi requires daos-client-tests already there is no need for daos-tests-internal to also require the empty daos-tests to bring in the daos-client-tests requirement.

Technically, yes, you are correct. Today at least. But having a daos-tests-internal which Requires: daos-tests allows us to feel comfortable that when we install daos-tests-internal we are always getting exactly what users would get by installing daos-tests plus whatever embargoed packages that we want for internal testing.

We are then free at any time to change up the dependencies in any way we want and will always be testing internally, an accurate (as can be) reflection of what users are going to experience by installing daos-tests externally.

Signed-off-by: Phillip Henderson <phillip.henderson@intel.com>

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1 · 2022-05-12T14:32:57Z

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8980/5/execution/node/349/log

daosbuild1 · 2022-05-12T14:33:30Z

Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8980/5/execution/node/432/log

daosbuild1 · 2022-05-12T14:33:33Z

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8980/5/execution/node/435/log

daosbuild1 · 2022-05-12T14:33:35Z

Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8980/5/execution/node/429/log

daosbuild1 · 2022-05-12T15:31:49Z

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8980/9/execution/node/436/log

daosbuild1 · 2022-05-12T15:32:21Z

Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8980/9/execution/node/418/log

daosbuild1 · 2022-05-12T15:35:19Z

Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8980/9/execution/node/421/log

Signed-off-by: Phillip Henderson <phillip.henderson@intel.com>

daosbuild1

LGTM. No errors found by checkpatch.

FYI: Errors found in lines not modified in the patch:

ci/functional/required_packages.sh:6:
(lint) client_ver appears unused. Verify use (or export if used externally). [SC2034]

brianjmurrell · 2022-05-12T17:37:14Z

 %package tests
 Summary: The entire DAOS test suite
-Requires: %{name}-client-tests-openmpi%{?_isa} = %{version}-%{release}
+Requires: %{name}-client-tests%{?_isa} = %{version}-%{release}


I'm not sure that you can do this all in one commit. This will cause testing on this branch to break until the pipeline-lib change lands. Unless you close landing on this branch after this until the pipeline-lib update lands.

I'm temporarily including installing the daos-client-tests-openmpi package through the Jenkins file until packaging in all branches generates a daos-test-internal package, at which point pipeline-lib can be updated to install it instead of daos-tests.

daosbuild1 · 2022-05-12T20:14:03Z

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-8980/10/display/redirect

Signed-off-by: Phillip Henderson <phillip.henderson@intel.com>

daosbuild1

LGTM. No errors found by checkpatch.

FYI: Errors found in lines not modified in the patch:

ci/functional/required_packages.sh:6:
(lint) client_ver appears unused. Verify use (or export if used externally). [SC2034]

Signed-off-by: Phillip Henderson <phillip.henderson@intel.com>

daosbuild1

LGTM. No errors found by checkpatch.

FYI: Errors found in lines not modified in the patch:

ci/functional/required_packages.sh:6:
(lint) client_ver appears unused. Verify use (or export if used externally). [SC2034]

Signed-off-by: Phillip Henderson <phillip.henderson@intel.com>

daosbuild1

LGTM. No errors found by checkpatch.

FYI: Errors found in lines not modified in the patch:

ci/functional/required_packages.sh:6:
(lint) client_ver appears unused. Verify use (or export if used externally). [SC2034]

phender · 2022-05-13T15:39:11Z

HW Small test failures in https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-8980/13 caused by:

May 13 10:10:08 wolf-135.wolf.hpdd.intel.com daos_server[98159]: ERROR: 1 fabric interface(s) not ready (requested: ib0)

Restarted Test Hardware

Signed-off-by: Phillip Henderson <phillip.henderson@intel.com>

daosbuild1

LGTM. No errors found by checkpatch.

FYI: Errors found in lines not modified in the patch:

ci/functional/required_packages.sh:6:
(lint) client_ver appears unused. Verify use (or export if used externally). [SC2034]

mjmac · 2022-05-17T16:50:26Z

@@ -1,5 +1,5 @@
 //
-// (C) Copyright 2020-2021 Intel Corporation.
+// (C) Copyright 2020-2022 Intel Corporation.


Hmm. Just realized that I forgot to set up my pre-commit hook in the new clone I'm using for el8 development. Fixed.

daosbuild1 · 2022-05-17T18:19:17Z

Test stage Unit Test completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-8980/15/execution/node/821/log

…8980) Limit daos_tests requiement to the non-openmpi daos-*-tests packages. Signed-off-by: Phillip Henderson <phillip.henderson@intel.com>

DAOS-10535 tests: Remove daos-tests daos-*-tests-openmpi requirement

ef646b2

Limit daos_tests requiement to the non-openmpi daos-*-tests packages. Signed-off-by: Phillip Henderson <phillip.henderson@intel.com>

phender requested a review from a team as a code owner May 10, 2022 14:57

daosbuild1 reviewed May 10, 2022

View reviewed changes

phender added 2 commits May 10, 2022 13:10

Fix typo.

1777230

Signed-off-by: Phillip Henderson <phillip.henderson@intel.com>

Fix other typo.

bbcb78c

Signed-off-by: Phillip Henderson <phillip.henderson@intel.com>

daosbuild1 reviewed May 10, 2022

View reviewed changes

phender requested a review from brianjmurrell May 10, 2022 17:14

daosbuild1 reviewed May 10, 2022

View reviewed changes

brianjmurrell suggested changes May 10, 2022

View reviewed changes

Adding daos-tests-internal package

8f4f4f0

Signed-off-by: Phillip Henderson <phillip.henderson@intel.com>

daosbuild1 reviewed May 12, 2022

View reviewed changes

Adding .rpmignore changes

58cc514

Signed-off-by: Phillip Henderson <phillip.henderson@intel.com>

daosbuild1 reviewed May 12, 2022

View reviewed changes

phender requested a review from JohnMalmberg May 12, 2022 16:39

phender marked this pull request as ready for review May 12, 2022 16:49

brianjmurrell reviewed May 12, 2022

View reviewed changes

Add installing required packages for CI.

fefd73f

Signed-off-by: Phillip Henderson <phillip.henderson@intel.com>

daosbuild1 reviewed May 12, 2022

View reviewed changes

Fix typo.

884aa5e

Signed-off-by: Phillip Henderson <phillip.henderson@intel.com>

daosbuild1 reviewed May 12, 2022

View reviewed changes

Fixing daos.spec

d346e49

Signed-off-by: Phillip Henderson <phillip.henderson@intel.com>

phender requested a review from brianjmurrell May 12, 2022 22:55

daosbuild1 reviewed May 12, 2022

View reviewed changes

Merge branch 'master' into DAOS-10535_master

0c6ed1a

Signed-off-by: Phillip Henderson <phillip.henderson@intel.com>

phender requested a review from a team as a code owner May 17, 2022 16:46

phender requested review from mjmac and removed request for a team May 17, 2022 16:46

daosbuild1 reviewed May 17, 2022

View reviewed changes

mjmac reviewed May 17, 2022

View reviewed changes

brianjmurrell approved these changes May 20, 2022

View reviewed changes

sylviachanoiyee approved these changes May 20, 2022

View reviewed changes

jolivier23 approved these changes May 20, 2022

View reviewed changes

jolivier23 merged commit cb24de2 into master May 20, 2022

jolivier23 deleted the DAOS-10535_master branch May 20, 2022 21:32

Conversation

phender commented May 10, 2022

Uh oh!

daosbuild1 left a comment

Choose a reason for hiding this comment

Uh oh!

daosbuild1 commented May 10, 2022

Uh oh!

daosbuild1 commented May 10, 2022

Uh oh!

daosbuild1 commented May 10, 2022

Uh oh!

daosbuild1 commented May 10, 2022

Uh oh!

daosbuild1 commented May 10, 2022

Uh oh!

daosbuild1 commented May 10, 2022

Uh oh!

daosbuild1 commented May 10, 2022

Uh oh!

daosbuild1 commented May 10, 2022

Uh oh!

daosbuild1 left a comment

Choose a reason for hiding this comment

Uh oh!

daosbuild1 left a comment

Choose a reason for hiding this comment

Uh oh!

brianjmurrell left a comment

Choose a reason for hiding this comment

Uh oh!

brianjmurrell commented May 10, 2022

Uh oh!

phender commented May 10, 2022

Uh oh!

phender commented May 10, 2022

Uh oh!

brianjmurrell commented May 10, 2022

Uh oh!

phender commented May 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daosbuild1 commented May 10, 2022

Uh oh!

brianjmurrell commented May 11, 2022

Uh oh!

daosbuild1 left a comment

Choose a reason for hiding this comment

Uh oh!

daosbuild1 commented May 12, 2022

Uh oh!

daosbuild1 commented May 12, 2022

Uh oh!

daosbuild1 commented May 12, 2022

Uh oh!

daosbuild1 commented May 12, 2022

Uh oh!

daosbuild1 commented May 12, 2022

Uh oh!

daosbuild1 commented May 12, 2022

Uh oh!

daosbuild1 commented May 12, 2022

Uh oh!

daosbuild1 left a comment

Choose a reason for hiding this comment

Uh oh!

brianjmurrell May 12, 2022

Choose a reason for hiding this comment

Uh oh!

phender May 12, 2022

Choose a reason for hiding this comment

Uh oh!

daosbuild1 commented May 12, 2022

Uh oh!

daosbuild1 left a comment

Choose a reason for hiding this comment

Uh oh!

daosbuild1 left a comment

Choose a reason for hiding this comment

Uh oh!

phender commented May 10, 2022 •

edited

Loading