Skip to content

DAOS-18905 build: fix in_list PATH check due to missing word-split #18482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
knard38 wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −7
Open

DAOS-18905 build: fix in_list PATH check due to missing word-split #18482

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d51c4d1
DAOS-18905 build: fix in_list PATH check due to missing word-split
kanard38 Jun 10, 2026
16925e4
DAOS-18905 build: make setup_local in_list checks set -e safe
kanard38 Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions utils/sl/setup_local.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#!/bin/bash
# /*
# * (C) Copyright 2016-2023 Intel Corporation.
# * (C) Copyright 2026 Hewlett Packard Enterprise Development LP
# * (C) Copyright 2025 Google LLC
# *
# * SPDX-License-Identifier: BSD-2-Clause-Patent
Expand Down Expand Up @@ -87,24 +88,23 @@ added="/ /usr /usr/local"
old_path="${PATH//:/ }"
echo OLD_PATH is "${old_path}"
for item in $list; do
in_list "${!item}" "${added}"
if [ $? -eq 1 ]; then
# shellcheck disable=SC2086
if ! in_list "${!item}" ${added}; then
continue
fi
export "${item?}"
added+=" ${!item}"
in_list "${!item}/bin" "${old_path}"
if [ $? -eq 1 ]; then
# shellcheck disable=SC2086
if ! in_list "${!item}/bin" ${old_path}; then
continue
fi
if [ -d "${!item}/bin" ]; then
PATH=${!item}/bin:$PATH
fi
done

in_list "${SL_PREFIX}/bin" "${old_path}"
# shellcheck disable=SC2181
if [ $? -eq 0 ]; then
# shellcheck disable=SC2086
if in_list "${SL_PREFIX}/bin" ${old_path}; then
PATH=$SL_PREFIX/bin:$PATH
fi
export PATH
Expand Down
Loading