DAOS-19132 rdb: Fix destination ranks in log messages#18481
Open
liw wants to merge 1 commit into
Open
Conversation
Rajesh observed log messages like these:
crt_rpc_complete_and_unlock(0x7efc3df4a620) [opc=0x7040000
(DAOS_RDB_MODULE:) rpcid=0x3637ab4c00003653 rank:tag=102:0]
failed, DER_OOG(-1019): 'Out of group or member list'
rdb_raft_rpc_cb() 14673705[207]: RPC 0 to rank 0 failed:
DER_OOG(-1019): 'Out of group or member list'
Apparently, rdb_raft_rpc_cb should log 'to rank 102' instead of 'to rank
0'. The issue is that depending on when the error happens the
destination rank in the request header may have yet to be initialized.
This patch returns to use cr_ep.ep_rank for request senders.
Signed-off-by: Li Wei <liwei@hpe.com>
Contributor
Author
|
With this patch, sending an RDB RPC to an out-of-group rank now produces: |
|
Ticket title is 'Destination ranks in rdb_raft_rpc_cb log messages may be incorrect' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rajesh observed log messages like these:
Apparently, rdb_raft_rpc_cb should log 'to rank 102' instead of 'to rank 0'. The issue is that depending on when the error happens the destination rank in the request header may have yet to be initialized. This patch returns to use cr_ep.ep_rank for request senders.
Steps for the author:
After all prior steps are complete: