Skip to content

DAOS-19127 build: patch isal_crypto#18470

Draft
daltonbohning wants to merge 2 commits into
masterfrom
dbohning/daos-19127
Draft

DAOS-19127 build: patch isal_crypto#18470
daltonbohning wants to merge 2 commits into
masterfrom
dbohning/daos-19127

Conversation

@daltonbohning

@daltonbohning daltonbohning commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Patch isal_crypto to support older NASM verions, such as for older versions of SLES.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@daltonbohning daltonbohning self-assigned this Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Ticket title is 'v2.8.0-rc1 / libisal_crypto does not build from source on Aurora'
Status is 'In Progress'
Labels: '2.8.0rc1,test_2.8.0rc'
https://daosio.atlassian.net/browse/DAOS-19127

@daltonbohning daltonbohning force-pushed the dbohning/daos-19127 branch from beda188 to 92bef00 Compare June 9, 2026 18:57
@daltonbohning
DAOS-19127 build: patch isal_crypto
6967a6e 
Patch isal_crypto to support older NASM verions, such as for older
version of SLES.

Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>
jolivier23
jolivier23 reviewed Jun 10, 2026
View reviewed changes
Comment thread utils/build.config Outdated
ucx=https://github.com/openucx/ucx.git

[patch_versions]
isal_crypto=https://github.com/intel/isa-l_crypto/commit/de6b07c73b33de927b470d6ba860502a12e9fa5e.diff

@jolivier23 jolivier23 Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's up to you but for hermetic build, it is better to download the patch into deps/patches/isal_crypto as we've done with several others. Though I see some https links under pmdk so it has diverged already from where we were at one point.

@daltonbohning daltonbohning Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do it that way then

jolivier23
jolivier23 previously approved these changes Jun 10, 2026
View reviewed changes
@jolivier23

jolivier23 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

I guess one comment is whether we can just install a newer nasm version or not. Looking at the patch description, it looks like it omits some code if nasm is too old and that may not be desired.

@daltonbohning

daltonbohning commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

I guess one comment is whether we can just install a newer nasm version or not. Looking at the patch description, it looks like it omits some code if nasm is too old and that may not be desired.

I didn't look too much into that because where I was needing this is on SLES 15.4, which is old and likely doesn't have upstream packages available

@daltonbohning
use deps/patches instead of https
95ba9da 
Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jolivier23 jolivier23 jolivier23 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@daltonbohning daltonbohning

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@daltonbohning @jolivier23