Skip to content

SRE-3827 test: assuming fault injection is enabled by default#18465

Open
janekmi wants to merge 1 commit into
masterfrom
janekmi/SRE-3827-change-fault_status-default
Open

SRE-3827 test: assuming fault injection is enabled by default#18465
janekmi wants to merge 1 commit into
masterfrom
janekmi/SRE-3827-change-fault_status-default

Conversation

@janekmi

@janekmi janekmi commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

If the fault_status executable is not available (e.g. on a light agent where DAOS is not installed) we cannot rule out there are tests to run. It does not change the behaviour when fault_status is available so no more tests will get run but less stages will get skipped without good reason when the test scope is restricted allowing to run a single fault injection test if necessary.

Fault injection test below picked arbitrarily.

Test-tag: test_daos_pipeline

Skip-unit-tests:true
Skip-NLT: true
Skip-unit-test-memcheck: true
Skip-func-vm: true
Skip-fault-injection-test: true
Skip-test-rpms: true

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

If the fault_status executable is not available we cannot rule out
there are tests to run. It does not change the behaviour when
fault_status is available so no more tests will get run but less stages
will get skipped without good reason when the test scope is restricted
allowing to run a single fault injection test if necessary.

Fault injection test below picked arbitrarily.

Test-tag: test_daos_pipeline

Skip-unit-tests:true
Skip-NLT: true
Skip-unit-test-memcheck: true
Skip-func-vm: true
Skip-fault-injection-test: true
Skip-test-rpms: true

Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Errors are Unable to load ticket data
https://daosio.atlassian.net/browse/SRE-3827

@janekmi janekmi marked this pull request as ready for review June 8, 2026 20:35
@janekmi janekmi requested review from a team as code owners June 8, 2026 20:35
@janekmi janekmi requested a review from grom72 June 8, 2026 20:39
@daltonbohning daltonbohning requested a review from phender June 8, 2026 21:31

@daltonbohning daltonbohning left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, though I'll let @phender comment if there is something this might interfere with.

@grom72 grom72 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please extend description with most common usecase:

If the fault_status executable is not available (for example on the test agent)
we cannot rule out there are tests to run. It does not change the behaviour when
fault_status is available so no more tests will get run but less stages
will get skipped without good reason when the test scope is restricted
allowing to run a single fault injection test if necessary.

@grom72

grom72 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@daos-stack/daos-gatekeeper please include in the final commit message the (e.g. on a light agent where DAOS is not installed) note

@grom72 grom72 self-requested a review June 9, 2026 16:56
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jun 9, 2026
@janekmi janekmi requested a review from a team June 11, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.

Development

Successfully merging this pull request may close these issues.

3 participants