DAOS-18881 test: fix the csum_error_logging test#18455
Open
janekmi wants to merge 8 commits into
Open
Conversation
Since #17828 faults injected by this test does not increase the NVMe device error counter. Instead a RAS event is emitted. The test has to be adjusted accordingly. Test-tag: test_csum_error_logging Skip-unit-tests:true Skip-NLT: true Skip-unit-test-memcheck: true Skip-func-vm: true Skip-fault-injection-test: true Skip-test-rpms: true Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
|
Ticket title is 'checksum/csum_error_logging.py:CsumErrorLog.test_csum_error_logging - failed due to Checksum Error Log not incremented' |
Should not be landed. Master Jenkinsfile is not able to run a single test employing fault injection. Please see the ticket for more details. Test-tag: test_csum_error_logging Skip-unit-tests:true Skip-NLT: true Skip-unit-test-memcheck: true Skip-func-vm: true Skip-fault-injection-test: true Skip-test-rpms: true Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
janekmi
force-pushed
the
janekmi/DAOS-18881-fix-csum_error_logging-pr
branch
from
50b260b to
56701a1
Compare
This reverts commit 56701a1. Doc-only: true
Contributor
Author
NiuYawei
previously approved these changes
Jun 8, 2026
| nr_xs_helpers: 1 | ||
| storage: auto | ||
| env_vars: | ||
| - DAOS_DMA_INIT_PCT=20 # workaround for DAOS-18194 |
Contributor
There was a problem hiding this comment.
It could be DAOS-18860. Please try merging master to pick 174dead .
Contributor
There was a problem hiding this comment.
Also, I don't think we should add a workaround for DAOS-18194 to a PR that is fixing DAOS-18881
daltonbohning
left a comment
daltonbohning
left a comment
Contributor
There was a problem hiding this comment.
Overall LGTM but I agree with Niu's comment about merging latest master
| nr_xs_helpers: 1 | ||
| storage: auto | ||
| env_vars: | ||
| - DAOS_DMA_INIT_PCT=20 # workaround for DAOS-18194 |
Contributor
There was a problem hiding this comment.
Also, I don't think we should add a workaround for DAOS-18194 to a PR that is fixing DAOS-18881
| self.log_step('Check checksum error logs') | ||
| checksum_errs = self.get_checksum_error_value(t_start, t_end) | ||
| self.log.info('Checksum Errors reported: %d', checksum_errs) | ||
| self.assertTrue(checksum_errs > 0, 'Checksum Errors not detected') |
Contributor
There was a problem hiding this comment.
This assert gives a slightly better error message
Suggested change
| self.assertTrue(checksum_errs > 0, 'Checksum Errors not detected') | |
| self.assertGreater(checksum_errs, 0, 'Checksum Errors not detected') |
…fix-csum_error_logging-pr
Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
Should not be landed. Master Jenkinsfile is not able to run a single test employing fault injection. Please see the ticket for more details. Test-tag: test_csum_error_logging Skip-unit-tests:true Skip-NLT: true Skip-unit-test-memcheck: true Skip-func-vm: true Skip-fault-injection-test: true Skip-test-rpms: true Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
This reverts commit 15ffb8d. Doc-only: true Skip-build: true
Contributor
Author
Re-tested without DAOS-18194/DAOS-18860 workaround |
daltonbohning
approved these changes
Jun 8, 2026
NiuYawei
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #17828 faults injected by this test does not increase the NVMe device error counter. Instead a RAS event is emitted. The test has to be adjusted accordingly.
Test-tag: test_csum_error_logging
Skip-unit-tests:true
Skip-NLT: true
Skip-unit-test-memcheck: true
Skip-func-vm: true
Skip-fault-injection-test: true
Skip-test-rpms: true
Steps for the author:
After all prior steps are complete: