Skip to content

DAOS-16661 common: PMDK error/warnings to VOS logging (#14923)#17595

Open
grom72 wants to merge 3 commits intorelease/2.6from
grom72/DAOS-16661-2.6
Open

DAOS-16661 common: PMDK error/warnings to VOS logging (#14923)#17595
grom72 wants to merge 3 commits intorelease/2.6from
grom72/DAOS-16661-2.6

Conversation

@grom72
Copy link
Contributor

@grom72 grom72 commented Feb 25, 2026

Integrate PMDK logging system w/ VOS logging

pmemobj error and warning messages are written by default to stderr and syslog(). PMDK enables redirecting logging messages to user-specific functions.

All error and warning messages are reported using the DAOS logging function, to ensure a coherent events view for VOS and related pmemobj functions.

Backport of #14923

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

Integrate PMDK logging system w/ VOS logging

pmemobj error and warning messages are written by default to stderr and syslog().
PMDK enables redirecting logging messages to user-specific functions.

All error and warning messages are reported using the DAOS logging function,
to ensure a coherent events view for VOS and related pmemobj functions.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
@github-actions
Copy link

github-actions bot commented Feb 25, 2026

Ticket title is 'Integrate PMDK logging system w/ VOS logging system.'
Status is 'Awaiting backport'
Labels: 'scrubbed_2.8'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16661

@daosbuild3
Copy link
Collaborator

@grom72 grom72 changed the title DAOS-16661 common: PMDK error/warnings to VOS logging DAOS-16661 common: PMDK error/warnings to VOS logging (#14923) Feb 25, 2026
Comment on lines 638 to 639
* Wed Feb 25 2026 Tomasz Gromadzki <tomasz.gromadzki@hpe.com> 2.6.-17
- pmemobj errors and warnings reported via DAOS logging system
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this require a bump to the release version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this require a bump to the release version?

Fixed in 42fb25a

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i mean why is it required to bump this?
you have no changes to the spec file, so you do not need to touch this file as far as i recall. so could you please explain why this is required (both here and the debian changelog)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i do not see any change to the packaging so im not clear why you are adding a new entry in the spec file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have inherited this approach from master branch indicating clearly that from now VOS log also contains libpmemobj errors/warnings.

* Wed Jul 30 2025 Tomasz Gromadzki <tomasz.gromadzki@hpe.com> 2.7.101-12
- pmemobj errors and warnings reported via DAOS logging system

It is a change that is visible outside the DAOS system.
For example, if somebody had a tool to parse DAOS/vos log, it must be prepared for new type of message (i.e. HARK).

Copy link
Contributor

@mchaarawi mchaarawi Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry but this does not make sense to me.. it sounds like the master change itself is wrong.
there is no packaging change here, no dependencies are being upgraded or added. what you are describing should not require a release version bump.
tools can rely on the library version for this distinction .. i do not see how anyone would use RPM versions for functionality or logging changes in their code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed: 85329f3

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

Doc-only: true
@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Feb 26, 2026
@grom72 grom72 marked this pull request as ready for review February 26, 2026 08:29
@grom72 grom72 requested review from a team as code owners February 26, 2026 08:29
@grom72
Copy link
Contributor Author

grom72 commented Feb 26, 2026

janekmi
janekmi previously approved these changes Feb 26, 2026
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority Ticket has high priority (automatically managed)

Development

Successfully merging this pull request may close these issues.

4 participants