DAOS-18608 ddb: md-on-ssd interactive open fix#17589
Open
Conversation
Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
|
Ticket title is 'ddb open fails (md-on-ssd + interactive)' |
kjacque
requested changes
Feb 23, 2026
Contributor
kjacque
left a comment
kjacque
left a comment
There was a problem hiding this comment.
I don't love the idea of slipping CGo into yet another file, usually we try to abstract this away.
Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
knard38
previously approved these changes
Feb 26, 2026
kjacque
previously approved these changes
Feb 26, 2026
Nasf-Fan
requested changes
Mar 2, 2026
src/control/cmd/ddb/main.go
Outdated
| if opts.VosPath != "" { | ||
| ctx.ctx.dc_pool_path = C.CString(string(opts.VosPath)) | ||
| defer C.free(unsafe.Pointer(ctx.ctx.dc_pool_path)) | ||
| cleanup := SetCString(&ctx.ctx.dc_pool_path, string(opts.SysdbPath)) |
Contributor
There was a problem hiding this comment.
cleanup := SetCString(&ctx.ctx.dc_pool_path, string(opts.VosPath))
Contributor
Author
There was a problem hiding this comment.
You are right! Thanks!
Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
github-actions
bot
added
the
priority
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps for the author:
After all prior steps are complete: