Added refreshing bar height in onLayout#71
Open
marcin-adamczewski wants to merge 1 commit intodanoz73:masterfrom
Open
Added refreshing bar height in onLayout#71marcin-adamczewski wants to merge 1 commit intodanoz73:masterfrom
marcin-adamczewski wants to merge 1 commit intodanoz73:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi ! There was an issue in our project that sometimes we weren't able to move bar handle to
the bottom of the bar. I discovered it was caused by "onCreateScrollProgressCalculator" method
which is called only once in onLayout method, but bar height was changing in subsequent onLayout calls. That caused VerticalScrollProgressCalculator and VerticalScreenPositionCalculator to use wrong bar height.
I broke your immutable VerticalScrollBoundsProvider class so it have update method now. IMHO it is better solution for view efficiency than creating new objects in on layout.