Skip to content

Change Units to Mbit#14

Open
dragon2611 wants to merge 1 commit intodanopstech:mainfrom
dragon2611:speedtest
Open

Change Units to Mbit#14
dragon2611 wants to merge 1 commit intodanopstech:mainfrom
dragon2611:speedtest

Conversation

@dragon2611
Copy link

@dragon2611 dragon2611 commented Jun 8, 2021

Change speedtest dashboard to show MegaBits as Value is in Megabits but dashboard was set to Bytes.

Related Issue

#11

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the Code of Conduct
  • I have updated the documentation accordingly.
  • All commits are GPG signed

Copy link

@sinnx3 sinnx3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change from original "Bps" to "bps" (proper Megabit per second formatting)

Incorrect Megabit per second formatting: Bps and decbits.

Reasoning:

Ookla's Speedtest.net measures in Megabits per second by default, not MegaBytes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants