bugfix - fix v0.3 release blockers (#542, #610, #612)#613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the final v0.3 release-hardening blockers and follows up on the docs review. The compiler/tooling fixes keep
incan testhelper packaging, Rust interop call-shape metadata, stdlib runtime dependencies, and collection error paths aligned with the intended v0.3 behavior. The docs work splits oversized stdlib reference pages into Divio-shaped reference/how-to/explanation pages, restores legacy RFCs to the modern metadata shape, removes manually short-wrapped Markdown prose across project docs, and updates the generated language reference source so CI no longer rewrites generated prose back into short lines.Type of change
docs/RFCs/*)Area(s)
Select the primary areas touched (used for review routing; labels are managed separately):
Key details
incan testincludes the stdlib helper modules needed for loweredResult.map_errtest code, and Rust interop no longer over-borrows by-value generic decode arguments when the selected method comes from an extension trait. Collection missing-key and invalid-count paths now raise the intended canonical key/value errors. The v0.3 docs are easier to reason about: release notes separate features from fixes, stdlib reference pages stay API-focused, and task/background material lives in how-to/explanation pages.std.regexdependency ownership stays with source imports and registry metadata rather than the always-present runtime crate. The generated language-reference writer now emits natural Markdown paragraphs so the generated-reference CI guard agrees with the docs prose policy.Testing / verification
make test/cargo testmake examples(if relevant)incan fmt --check .(if relevant)Manual verification notes:
make -C /Users/danny/Development/encero/incan pre-commitpassed after the final docs/generator commit: formatting, rustdoc coverage, 2438 nextest tests, 5 filtered cargo tests, clippy, cargo-deny, smoke-test-fast, examples checked 57 / ran 34 / failed 0, benchmark smoke builds checked 9 / failed 0.make -C workspaces/docs-site docs-buildpassed after the RFC frontmatter and stdlib docs split.cargo run -p incan_core --bin generate_lang_referencepassed, and ashasumbefore/after idempotence check confirmed regeneratedlanguage.mdandfeature_inventory.mdstay stable.*.md, excluding.agents,__research__,workspaces/docs-site/.venv, generated site output, and vendored license files, found 0 adjacent short-prose candidates.git diff --checkpassed.Docs impact
If docs updated:
workspaces/docs-site/docs/release_notes/0_3.md,workspaces/docs-site/docs/language/reference/stdlib/graph.md,workspaces/docs-site/docs/language/how-to/working_with_graphs.md,workspaces/docs-site/docs/language/explanation/graph_model.md,workspaces/docs-site/docs/language/how-to/hashing_data.md,workspaces/docs-site/docs/language/how-to/logging.md,workspaces/docs-site/docs/language/how-to/regular_expressions.md, plus broad Markdown prose unwraps across project docs.RFC lifecycle note: this PR touches RFC Markdown for metadata modernization and prose reflow only; it does not implement or advance any active RFC lifecycle state.
Checklist
Closes #542
Closes #610
Closes #612