bugfix - preserve by-value generic Rust call arguments (#609)#611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes Rust interop call emission for metadata-backed associated functions whose inspected signature takes a generic parameter by value, such as
decode<T: Buf>(buf: T). The typechecker now preserves plain Rust type variables as exact by-value call-site parameters and the backend honors that explicit external signature, so owned cursor arguments are passed directly instead of being fallback-borrowed.Type of change
docs/RFCs/*)Area(s)
Select the primary areas touched (used for review routing; labels are managed separately):
Key details
FileDescriptorSet.decode(cursor), now pass owned cursor values directly when the Rust signature acceptsT: Bufby value.TypeVar, and method emission keeps explicit external generic params on the external call-arg path.Testing / verification
make test/cargo testmake examples(if relevant)incan fmt --check .(if relevant)Manual verification notes:
make pre-commitpassed after the final commit, including formatting, rustdoc, 2435 nextest tests, LSP focused tests, clippy, cargo-deny, and smoke-test-fast.decode<T: DecodeBuf>(T)helper crate.Docs impact
If docs updated:
workspaces/docs-site/docs/release_notes/0_3.mdChecklist
Closes #609