feature - modernize InQL for v0.3 showcase (#25)#29
Draft
dannymeijer wants to merge 1 commit into
Draft
Conversation
d8d941b to
370d02a
Compare
c1aa774 to
ddd1e97
Compare
ddd1e97 to
7788b79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR modernizes InQL #25 for the Incan v0.3 RC2 toolchain and turns the branch into a stronger InQL showcase. It updates the scalar expression surface around union-backed literals and structured lowering errors, adopts additional v0.3 language features where they improve the package shape, refreshes tests/docs/examples for the current API shape, regenerates the lockfile, and adds an ignore rule so local agent state under
.agents/state/stays out of public PRs.The branch now passes end-to-end with the local Incan main-worker fix for incan#617, including the
pub::inqlconsumer smoke check for alias-backed public helper exports.Type of change
docs/rfcs/*)Area(s)
Select the primary areas touched (labels sync from checked lines when the triage workflow runs):
Key details
lit(...), builder-backed filters/projections/aggregates, Session execution paths, and current DataFusion-backed behavior.lit(...),matchover union values, structuredResult[..., SubstraitLoweringError]fallible lowering paths,Result.map_err(...), tuple-target comprehensions,if letfor optional proto unwrapping, value enums for stable string-backed categories, nativeu32Substrait anchors, and public symbol aliases for helper forwarding.Testing / verification
make ci(ormake fmt-check,make build,make test)Manual verification notes:
/Users/danny/Development/encero/incan/target/debug/incan --versionreportsincan 0.3.0-rc2after rebuilding the main Incan worker at8003bdad.make ci INCAN=/Users/danny/Development/encero/incan/target/debug/incanpasses fmt-check, test-style, library build, all 88 InQL tests, and thepub::inqlconsumer smoke check.make build-locked INCAN=/Users/danny/Development/encero/incan/target/debug/incanandmake test-locked INCAN=/Users/danny/Development/encero/incan/target/debug/incanpassed after regeneratingincan.lockwith RC2.git diff --check HEADpassed.Docs impact
If docs updated:
docs/architecture.md,docs/language/explanation/*,docs/language/reference/*,docs/rfcs/*,docs/release_notes/v0_1.md,examples/*Checklist
Closes #25