This repository was archived by the owner on Mar 15, 2021. It is now read-only.
WIP: Support Rails 5 #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set up testing environment. Rails 5 (and thus ActiveRecord 5) supports only Ruby 2.2.2+ so we exclude lower versions from AR5 testing.
Organise active_record code by gem version number also.
ActiveRecord 5 uses the provided model's namespace instead of the CTEs. So we explicitly specify the table whose id field we want to use.
…arning This prevents the following warning from appearing: ``` DEPRECATION WARNING: table_exists? is deprecated and will be removed from Rails 5.1 (use #data_source_exists? instead) ```
Fix deprecation warnings about alias_method_chain
Author
|
🤔 Arel is pretty hard to understand. I'd definitely appreciate help with this |
Author
|
IIRC the problems I was having here were related to bind parameters. I just discovered that |
Author
|
For anyone subscribed to this PR, there's a new gem that you might want to use instead: https://github.com/danmcclain/postgres_ext/issues/3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repo doesn't have the Rails 5.0 & 5.1 commits that others had already contributed, so I merged https://github.com/nickgal/postgres_ext/tree/as_rails-5-1. I'm currently working on 5.2 support.
CC @aschuster3 @nickgal @shaneog