Skip to content

fixed #14547 - store absolute path in FileWithDetails (fixes slow lead up to analysis with a lot of input files)#8282

Merged
firewave merged 3 commits intodanmar:mainfrom
firewave:cache-abs
Mar 2, 2026
Merged

fixed #14547 - store absolute path in FileWithDetails (fixes slow lead up to analysis with a lot of input files)#8282
firewave merged 3 commits intodanmar:mainfrom
firewave:cache-abs

Conversation

@firewave
Copy link
Collaborator

@firewave firewave commented Mar 1, 2026

No description provided.

@firewave
Copy link
Collaborator Author

firewave commented Mar 1, 2026

before:

DISABLE_VALUEFLOW=1 ./cppcheck -D__GNUC__ libexplain-1.4 -q -E > /dev/null  21,44s user 23,19s system 99% cpu 44,960 total

after:

DISABLE_VALUEFLOW=1 ./cppcheck -D__GNUC__ libexplain-1.4 -q -E > /dev/null  6,44s user 0,08s system 99% cpu 6,578 total

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2026

@firewave
Copy link
Collaborator Author

firewave commented Mar 1, 2026

I am also filtering out the files before trying to de-duplicate them. That should reduce the calls even more if files are filtered. Also will provide better output when we start logging the filtered out files somewhere in the future.

@firewave firewave changed the title fixed #14547 - store absolute path in FileWithDetails (fixes slow start-up with a lot of input files) fixed #14547 - store absolute path in FileWithDetails (fixes slow lead up to analysis with a lot of input files) Mar 1, 2026
@danmar
Copy link
Owner

danmar commented Mar 2, 2026

before:

DISABLE_VALUEFLOW=1 ./cppcheck -D__GNUC__ libexplain-1.4 -q -E > /dev/null  21,44s user 23,19s system 99% cpu 44,960 total

after:

DISABLE_VALUEFLOW=1 ./cppcheck -D__GNUC__ libexplain-1.4 -q -E > /dev/null  6,44s user 0,08s system 99% cpu 6,578 total

Wow! Nice speedup!

@firewave
Copy link
Collaborator Author

firewave commented Mar 2, 2026

Wow! Nice speedup!

Well - it was a bad regression - so nothing gained.

@firewave firewave merged commit 4177083 into danmar:main Mar 2, 2026
70 checks passed
@firewave firewave deleted the cache-abs branch March 2, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants