Skip to content

fixed #13788 - CI-unixish-docker.yml: added ubuntu:25.10 / cleanups#7472

Merged
firewave merged 1 commit intodanmar:mainfrom
firewave:ub2504
Feb 14, 2026
Merged

fixed #13788 - CI-unixish-docker.yml: added ubuntu:25.10 / cleanups#7472
firewave merged 1 commit intodanmar:mainfrom
firewave:ub2504

Conversation

@firewave
Copy link
Collaborator

No description provided.


# TODO: is this actually applied to the guest?
env:
# TODO: figure out why there are cache misses with PCH enabled
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out this was working just fine in this workflow although we forgot to disable the precompiled headers. So we should be able to enable them in the other jobs as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first run also got cache hits which was unexpected. Turns out we are lacking the branch name in the cache key which causes it to be used across all builds (IIRC I assumed the cache is limited to the branch). So any PR will affect the cache of main builds.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also create a new cache with each build because it automatically appends a timestamp. That is done to prevent issues with concurrent access (see hendrikmuhs/ccache-action#117). It seems that might not be necessary for branches but since multiple pushes trigger multiple builds we cannot disable this. That would require us to cancel the already running builds (see https://trac.cppcheck.net/ticket/12325).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope of this ticket - I filed https://trac.cppcheck.net/ticket/14490 about it.

@firewave firewave changed the title fixed #13788 - CI-unixish-docker.yml: replaced ubuntu:24.10 with ùbuntu:25.04 / cleanups fixed #13788 - CI-unixish-docker.yml: replaced ubuntu:24.10 with ubuntu:25.04 / cleanups Apr 18, 2025
@firewave firewave changed the title fixed #13788 - CI-unixish-docker.yml: replaced ubuntu:24.10 with ubuntu:25.04 / cleanups fixed #13788 - CI-unixish-docker.yml: replaced ubuntu:24.10 with ubuntu:25.10 / cleanups Feb 13, 2026
@firewave
Copy link
Collaborator Author

Ubuntu 25.04 is already EOL so move on to 25.10.

@firewave firewave changed the title fixed #13788 - CI-unixish-docker.yml: replaced ubuntu:24.10 with ubuntu:25.10 / cleanups fixed #13788 - CI-unixish-docker.yml: added ubuntu:25.10 / cleanups Feb 13, 2026
@firewave firewave force-pushed the ub2504 branch 2 times, most recently from b43d5cc to deaedf7 Compare February 13, 2026 09:55
@firewave firewave marked this pull request as ready for review February 13, 2026 09:55
@sonarqubecloud
Copy link

@firewave firewave merged commit 4f03f09 into danmar:main Feb 14, 2026
68 checks passed
@firewave firewave deleted the ub2504 branch February 14, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants