Skip to content

allow value field name in combination with builder#131

Open
robamu wants to merge 1 commit intomainfrom
allow-value-field-names-with-builder-2
Open

allow value field name in combination with builder#131
robamu wants to merge 1 commit intomainfrom
allow-value-field-names-with-builder-2

Conversation

@robamu
Copy link
Collaborator

@robamu robamu commented Mar 13, 2026

Fixes #126

@robamu robamu requested review from danlehmann and estebank March 13, 2026 09:15
@danlehmann
Copy link
Owner

Thanks for the fix! Quick question: What if we made it a tuple struct instead? That .0 wouldn't clash with anything ever. Happy to merge as-is though.

Regardless, would you mind adding a note to the changelog?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Field name value in combination with the builder API is problematic with v2

2 participants