#37 Update tests for py3.13 and Windows and macOS#39
Open
adiroiban wants to merge 12 commits intodanifus:masterfrom
Open
#37 Update tests for py3.13 and Windows and macOS#39adiroiban wants to merge 12 commits intodanifus:masterfrom
adiroiban wants to merge 12 commits intodanifus:masterfrom
Conversation
Author
|
I am working on this on my fork to get all GitHub Action tests pass. I am using this PR to document the reasoning behind the changes Once all the tests pass, I will request a review. |
4551f74 to
1bc97ab
Compare
Author
|
All tests pass on win, macos and linux from py 3.9 to 3.13 you can check the result from GitHub Actions here adiroiban#1 |
Owner
|
Thanks for the updates. Looks pretty good from a quick review. I'll have a chance to look at this in more detail later this week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37
This updates the test suite to run with Python 3.13.
The
os.path.splitdrivebehaviour was update to match the one for Python 3.11 and newer.... with a hackish backport for 3.9 and 3.10It also enables the tests for GitHub Actions on Windows and macOS
To simplify testing, I have converted to code to run with pytest.
some stdlib code was removed as it was deprecated in python 3.13
The plan is to use pytest for running the tests.
The large file tests are disabled for now as they were not skipped by default for pytest.
Also, flake8 tests are not triggered on GitHub Actions are there are many errors.
My plan is to use
ruffinstead of flake8 so that we can get automatic fixes.The contributing documentation was updated to no longer required tox.
It's hard to run local tests for all supported Python version and all supported operating systems.
As a start, you try to get the test passing using your preferred Python version.
On the PR is created, GitHub Action will trigger all the tests.
You can then check the result and see what needs to be done to fix the tests.
For example use use action-tmate to debug the tests and get access to Windows, Linux or macOS.