Open
Conversation
Author
|
p/s: Tested on my system and LiSa works perfectly with this fix |
Owner
|
Hi, great work, thank you for all your commits. |
Author
Ooops. I created the PR for the fix only and then i tried working on yara for my personal purpose and all commits were merged to here. Damn let me see if i can remove them |
EvilWatermelon
left a comment
There was a problem hiding this comment.
Both values do not exist by default and if there is no value at both of them then Lisa will return a KeyError
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New version of radare2 changed
minopszandmaxopsztocore(old:bin). This commit fixes thetask failedwhen user submit a binary. Cred to @AlbertoFDR forminopszfix and @xchaoinfo forr2pipeopen