Skip to content

Fix #21 KeyError: 'minopsz'#24

Open
dmknght wants to merge 6 commits intodanielpoliakov:masterfrom
dmknght:master
Open

Fix #21 KeyError: 'minopsz'#24
dmknght wants to merge 6 commits intodanielpoliakov:masterfrom
dmknght:master

Conversation

@dmknght
Copy link

@dmknght dmknght commented Dec 16, 2021

New version of radare2 changed minopsz and maxopsz to core (old: bin). This commit fixes the task failed when user submit a binary. Cred to @AlbertoFDR for minopsz fix and @xchaoinfo for r2pipe open

@dmknght
Copy link
Author

dmknght commented Dec 16, 2021

p/s: Tested on my system and LiSa works perfectly with this fix

@danielpoliakov
Copy link
Owner

Hi, great work, thank you for all your commits.
As the pull requests deals with minopsz radare2 issue, I'd rather handle the remaining (pep8, typos, yara) in separate pull request.

@dmknght
Copy link
Author

dmknght commented Jan 4, 2022

Hi, great work, thank you for all your commits. As the pull requests deals with minopsz radare2 issue, I'd rather handle the remaining (pep8, typos, yara) in separate pull request.

Ooops. I created the PR for the fix only and then i tried working on yara for my personal purpose and all commits were merged to here. Damn let me see if i can remove them

@markelbsk markelbsk mentioned this pull request Mar 1, 2022
Copy link

@EvilWatermelon EvilWatermelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both values do not exist by default and if there is no value at both of them then Lisa will return a KeyError

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants