fix: Remove informational console.error from hooks to prevent false errors #572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
console.error()calls across 25 hook filesconsole.error()calls for real errors and security eventsProblem
All PAI hooks use
console.error()for both informational/progress messages AND actual errors. Claude Code interprets any stderr output from a hook as a failure, displaying "hook error" to the user even when hooks execute successfully.This means every session shows multiple false "hook error" messages during normal operation — at startup (SessionStart hooks), on every prompt (UserPromptSubmit hooks), and on tool use (PreToolUse hooks).
Fix
Systematically classified all 220
console.error()calls across 27 hook files:Files modified (25)
Hook files (15): LoadContext, StopOrchestrator, UpdateTabTitle, SoulEvolution, RelationshipMemory, SessionSummary, AgentOutputCapture, AutoWorkCreation, CheckVersion, QuestionAnswered, SetQuestionTab, ImplicitSentimentCapture, ExplicitRatingCapture, WorkCompletionLearning, SecurityValidator
Handler files (7): VoiceNotification, UpdateCounts, ISCValidator, TabState, SystemIntegrity, ResponseCapture, RebuildSkill
Lib files (3): notifications, observability, change-detection
Remaining console.error calls (24, all legitimate)
Test plan
Fixes #477
🤖 Generated with Claude Code