fix(observability): auto-install dependencies on first run#550
Open
wojteksbt wants to merge 1 commit intodanielmiessler:mainfrom
Open
fix(observability): auto-install dependencies on first run#550wojteksbt wants to merge 1 commit intodanielmiessler:mainfrom
wojteksbt wants to merge 1 commit intodanielmiessler:mainfrom
Conversation
When running `manage.sh start` after a fresh download, the server would fail silently because dependencies weren't installed. The script reported success but ports weren't bound. This adds an `install_deps_if_needed` function that checks for specific binaries (tsc for server, vite for client) and runs `bun install` if they're missing. Checking for specific files rather than just directory existence handles cases where node_modules exists but is corrupted. Fixes danielmiessler#548 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install_deps_if_needed()function tomanage.shbun installwhen dependencies are missingstartandstart-detachedcommandsProblem
When running
manage.sh startafter a fresh clone/download, the server fails silently because dependencies aren't installed. The script outputs "✅ Observability running" but ports aren't actually bound.Solution
Check for required binaries before starting:
tsc→ checksnode_modules/.bin/tscvite→ checksnode_modules/.bin/viteIf missing, runs
bun installautomatically.Test plan
Fixes #548
🤖 Generated with Claude Code