Repository navigation
Report.ts files bugs without the template's required "Before submitting" checklist, and keeps no record that search ran - #2648
Open
pareidox wants to merge 1 commit into
Conversation
…ng" checklist, and keeps no record that search ran Filed from a LifeOS install with the Report tool; the negative control and the green run are in the PR body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2647.
Version
LifeOS 8.761.0 · attestation: not run
What is broken
Report.ts build --kind issuewrites a body with no "Before submitting" section.file --yesposts it withgh issue create --body-file, which skips the issue form, so a bug filed through the tool arrives without the three checkboxesbug_report.ymlmarksrequired: true. Of the 35 issues carrying the tool'slifeos-reportmarker, 33 have no checklist; the two that do (#2641, #2642) got it by hand edit, and the newest (#2646) has none. The tool also keeps no record thatsearchran, so nothing backs that box even if it were there.Intents/Report.md:5says the tool makes the template's fields "the only shape a bug can take", and:10says "No filing exists without asearchbefore it".Where (file:line)
LifeOS/install/skills/LifeOS/Tools/Report.ts:262-276(renderIssue):291-312(buildReport);searchkeeps no record::516-528.github/ISSUE_TEMPLATE/bug_report.yml(checks,required: true)LifeOS/install/skills/LifeOS/Intents/Report.md:5,:10LifeOS/Tools/Report.tsandLifeOS/Intents/Report.mdare identical copiesRepro on a clean tree
Negative control
Probe:
cd /tmp/rtest.tGE1/up && sh /tmp/rtest.tGE1/repro.sh· exit 1 · captured 2026-11-07T04:35:05.203ZSuggested fix
Options I considered:
--clean-tree, and the redaction self-check plus the user's read. This is the one in the diff.How 3 works:
searchsavessearch.json(every term set it ran, the repo and the hit count) when at least one leg reached GitHub.build --kind issuerefuses with exit 2 when there is none, unless--searched-by-handsays the user searched withoutgh(the existing no-auth path inIntents/Report.mdstays open). The terms searched are listed under the checklist.unmodifiedattestation. Otherwise it ticks only on--clean-tree, which is the user's own statement that the probe ran against an unmodified copy. The probe's command is in the body so a reader can check it. Without either, the box is left unticked with the reason.report.mdbefore anything posts. Redaction is pattern-based, so the user's read is what makes this box true.bug_report.ymlword for word.Intents/Report.mdis updated to match.Testing: the red and green runs below are the same command in the same clone of main at f6ab5e0; the green one ran after
git apply --directory=LifeOS/installwith the diff below..github/scripts/leak-scan.ts --stagedon the patched files: no blocking findings.Scope:
LifeOS/skill is the same file and needs the same change;pronly carries install-relative paths, so it is not in this diff.prlayout fix and theFixes #Nlink, because Report.ts pr cannot apply any patch to the release repo's LifeOS/install/ layout (plus two file→pr defects) #2485 says both are already in the next release./feedback(skills/Errata/Tools/Send.ts) also files here withgh issue createand no checklist. It uses its own format, so I left it out.Verified after fix
Probe:
cd /tmp/rtest.tGE1/up && sh /tmp/rtest.tGE1/repro.sh· exit 0 · captured 2026-11-07T04:35:05.286ZEnvironment
Before submitting
Searched for:
Before submitting checklist,Report.ts checklist,issue template required checkboxes,Report.ts search record