Skip to content

Another attempt at providing bullet-proof deallocation. #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DarkDust wants to merge 1 commit into from
Closed

Another attempt at providing bullet-proof deallocation. #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions DFColorWell/DFColorWell.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,31 @@ - (instancetype)init
return self;
}

- (void) dealloc {
[[NSNotificationCenter defaultCenter] removeObserver:self];

if ([NSColorPanel sharedColorPanelExists]) {
NSColorPanel *panel = [NSColorPanel sharedColorPanel];
BOOL needToModifyTarget = NO;

@try {
// The NSColorPanel only has a setter for the target but no getter. But it has a private
// variable named "_target" which we can query using KVC (this is App Store safe). If
// Apple ever decides to remove the variable, the `valueForKey:` will throw an exception
// so we need to be prepared for that.
id target = [panel valueForKey:@"target"];
needToModifyTarget = target == self;
}
@catch (NSException *exception) {
}

if (needToModifyTarget) {
panel.target = nil;
panel.action = NULL;
}
}
}

- (void) _generateColors {

_colorMatrix = [NSMutableDictionary new];
Expand Down