Master #11
Open
Master #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handles deactivation better. Also add delegate methods so delegate knows when user will/did choose a color.
Author
|
Sorry, this PR includes (by accident) more than just the KVO fix mentioned above. If you'd rather not take the four other changes, let me know and I can resubmit a more targeted PR. IMHO, the other changes are worth considering. |
Owner
|
Hey, looks great viewing from my phone. I'm going to take a closer look and merge later on. Don't worry about the pull request, strictly speaking yes, but it's a small project I can't pretend it is that important. |
Owner
|
Sorry for neglecting the pull request. There are been some KVO improvements and other improvements since this pull request. If you are interested in pushing some changes upstream then let me know otherwise I'll close this without merging. Sorry again for taking years to reply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since setColor calls willChangeValueForKey/didChangeValueForKey manually, we need to tell the KVO machinery to not automatically notify observers, otherwise observers get two notifications each time .color changes.